From 2205a60c1c999406b94b05d40b8a9630b0cc5324 Mon Sep 17 00:00:00 2001 From: Mark Fisher Date: Wed, 9 Dec 2009 18:31:06 +0000 Subject: [PATCH] INT-810 Removed "thread-pool-task-executor" element now that Spring 3.0's "task" namespace provides an "executor" element. --- ...pIdleChannelAdapterParserTests-context.xml | 5 ++- .../osgi/config/xml/base-bus-config.xml | 10 +++--- .../xml/IntegrationNamespaceHandler.java | 1 - ...rentAggregatorIntegrationTests-context.xml | 14 ++++---- ...sageAggregatorIntegrationTests-context.xml | 15 ++++----- ...aultMessageAggregatorIntegrationTests.java | 20 +++++++----- .../publishSubscribeChannelParserTests.xml | 10 +++--- ...boundChannelAdapterParserTests-context.xml | 10 +++--- .../config/xml/innerdefaware.properties | 32 ++++++++++++++----- .../pollingEndpointErrorHandlingTests.xml | 14 ++++---- 10 files changed, 77 insertions(+), 54 deletions(-) diff --git a/org.springframework.integration.mail/src/test/java/org/springframework/integration/mail/config/ImapIdleChannelAdapterParserTests-context.xml b/org.springframework.integration.mail/src/test/java/org/springframework/integration/mail/config/ImapIdleChannelAdapterParserTests-context.xml index e94a116e79..3ca8b78dd4 100644 --- a/org.springframework.integration.mail/src/test/java/org/springframework/integration/mail/config/ImapIdleChannelAdapterParserTests-context.xml +++ b/org.springframework.integration.mail/src/test/java/org/springframework/integration/mail/config/ImapIdleChannelAdapterParserTests-context.xml @@ -1,11 +1,14 @@ bar - + \ No newline at end of file diff --git a/org.springframework.integration.osgi/src/test/java/org/springframework/integration/osgi/config/xml/base-bus-config.xml b/org.springframework.integration.osgi/src/test/java/org/springframework/integration/osgi/config/xml/base-bus-config.xml index d0d2495078..b172a63904 100644 --- a/org.springframework.integration.osgi/src/test/java/org/springframework/integration/osgi/config/xml/base-bus-config.xml +++ b/org.springframework.integration.osgi/src/test/java/org/springframework/integration/osgi/config/xml/base-bus-config.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task-3.0.xsd + http://www.springframework.org/schema/integration/integration-control-bus http://www.springframework.org/schema/integration/integration-control-bus/spring-integration-bus-1.0.xsd + http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration-2.0.xsd"> @@ -31,6 +33,6 @@ - - + + diff --git a/org.springframework.integration/src/main/java/org/springframework/integration/config/xml/IntegrationNamespaceHandler.java b/org.springframework.integration/src/main/java/org/springframework/integration/config/xml/IntegrationNamespaceHandler.java index 3b88fe32dc..0f19c9dbdf 100644 --- a/org.springframework.integration/src/main/java/org/springframework/integration/config/xml/IntegrationNamespaceHandler.java +++ b/org.springframework.integration/src/main/java/org/springframework/integration/config/xml/IntegrationNamespaceHandler.java @@ -55,7 +55,6 @@ public class IntegrationNamespaceHandler extends AbstractIntegrationNamespaceHan registerBeanDefinitionParser("poller", new PollerParser()); registerBeanDefinitionParser("annotation-config", new AnnotationConfigParser()); registerBeanDefinitionParser("application-event-multicaster", new ApplicationEventMulticasterParser()); - registerBeanDefinitionParser("thread-pool-task-executor", new ThreadPoolTaskExecutorParser()); registerBeanDefinitionParser("publisher", new PublisherParser()); } diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/ConcurrentAggregatorIntegrationTests-context.xml b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/ConcurrentAggregatorIntegrationTests-context.xml index 8aaf94aa0e..2c76e28c00 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/ConcurrentAggregatorIntegrationTests-context.xml +++ b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/ConcurrentAggregatorIntegrationTests-context.xml @@ -1,10 +1,11 @@ + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xmlns:beans="http://www.springframework.org/schema/beans" + xmlns:task="http://www.springframework.org/schema/task" + xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task.xsd + http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd"> @@ -17,8 +18,7 @@ - + diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests-context.xml b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests-context.xml index 416df66f4c..6b98d4f318 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests-context.xml +++ b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests-context.xml @@ -1,10 +1,11 @@ + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xmlns:beans="http://www.springframework.org/schema/beans" + xmlns:task="http://www.springframework.org/schema/task" + xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task.xsd + http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd"> @@ -18,12 +19,10 @@ - + - \ No newline at end of file diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests.java b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests.java index be11bd781a..633fb2cabe 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests.java +++ b/org.springframework.integration/src/test/java/org/springframework/integration/aggregator/integration/DefaultMessageAggregatorIntegrationTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2008 the original author or authors. + * Copyright 2002-2009 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -13,6 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.springframework.integration.aggregator.integration; import static org.hamcrest.CoreMatchers.is; @@ -26,6 +27,7 @@ import java.util.Map; import org.junit.Test; import org.junit.runner.RunWith; + import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Qualifier; import org.springframework.integration.aggregator.AbstractMessageAggregator; @@ -40,7 +42,6 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; /** * @author Alex Peters * @author Iwein Fuld - * */ @RunWith(SpringJUnit4ClassRunner.class) @ContextConfiguration @@ -48,14 +49,15 @@ public class DefaultMessageAggregatorIntegrationTests { @Autowired @Qualifier("input") - MessageChannel input; + private MessageChannel input; @Autowired @Qualifier("output") - PollableChannel output; + private PollableChannel output; @Autowired - AbstractMessageAggregator aggregator; + private AbstractMessageAggregator aggregator; + @Test public void configOk() throws Exception { @@ -71,15 +73,17 @@ public class DefaultMessageAggregatorIntegrationTests { } Object payload = output.receive().getPayload(); assertThat(payload, is(List.class)); - assertTrue(payload + " doesn't contain all of {0,1,2,3,4}", ((List) payload).containsAll(Arrays.asList(0, 1, 2, - 3, 4))); + assertTrue(payload + " doesn't contain all of {0,1,2,3,4}", + ((List) payload).containsAll(Arrays.asList(0, 1, 2, 3, 4))); } - Map stubHeaders(int sequenceNumber, int sequenceSize, int correllationId) { + + private Map stubHeaders(int sequenceNumber, int sequenceSize, int correllationId) { Map headers = new HashMap(); headers.put(MessageHeaders.SEQUENCE_NUMBER, sequenceNumber); headers.put(MessageHeaders.SEQUENCE_SIZE, sequenceSize); headers.put(MessageHeaders.CORRELATION_ID, correllationId); return headers; } + } diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/config/publishSubscribeChannelParserTests.xml b/org.springframework.integration/src/test/java/org/springframework/integration/config/publishSubscribeChannelParserTests.xml index 82a940ef99..a9fc6d0001 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/config/publishSubscribeChannelParserTests.xml +++ b/org.springframework.integration/src/test/java/org/springframework/integration/config/publishSubscribeChannelParserTests.xml @@ -2,10 +2,10 @@ + xmlns:task="http://www.springframework.org/schema/task" + xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task.xsd + http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd"> @@ -21,7 +21,7 @@ - + diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/MethodInvokingOutboundChannelAdapterParserTests-context.xml b/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/MethodInvokingOutboundChannelAdapterParserTests-context.xml index 1023262f06..9e8f1a1d22 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/MethodInvokingOutboundChannelAdapterParserTests-context.xml +++ b/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/MethodInvokingOutboundChannelAdapterParserTests-context.xml @@ -2,10 +2,10 @@ + xmlns:task="http://www.springframework.org/schema/task" + xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task.xsd + http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd"> @@ -25,6 +25,6 @@ - + diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/innerdefaware.properties b/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/innerdefaware.properties index ea07eb36bb..bab247be53 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/innerdefaware.properties +++ b/org.springframework.integration/src/test/java/org/springframework/integration/config/xml/innerdefaware.properties @@ -17,9 +17,13 @@ splitter-inner-success=\ splitter-inner-success-with-poller=\ \ \ \ @@ -34,14 +38,18 @@ splitter-inner-success-with-poller=\ \ \ \ - \ + \ splitter-inner-success-with-poller-reversed-order=\ \ \ \ @@ -56,7 +64,7 @@ splitter-inner-success-with-poller-reversed-order=\ \ \ \ - \ + \ splitter-ref-success=\ \ @@ -272,9 +280,13 @@ aggregator-ref-success=\ aggregator-inner-concurrent-success=\ \ \ \ @@ -289,14 +301,18 @@ aggregator-inner-concurrent-success=\ \ \ \ - \ + \ aggregator-inner-concurrent-success-reorder-bean-poller=\ \ \ \ @@ -311,7 +327,7 @@ aggregator-inner-concurrent-success-reorder-bean-poller=\ \ \ \ - \ + \ aggregator-failure-refAndBean=\ \ diff --git a/org.springframework.integration/src/test/java/org/springframework/integration/endpoint/pollingEndpointErrorHandlingTests.xml b/org.springframework.integration/src/test/java/org/springframework/integration/endpoint/pollingEndpointErrorHandlingTests.xml index 172782b162..f49f51b4e1 100644 --- a/org.springframework.integration/src/test/java/org/springframework/integration/endpoint/pollingEndpointErrorHandlingTests.xml +++ b/org.springframework.integration/src/test/java/org/springframework/integration/endpoint/pollingEndpointErrorHandlingTests.xml @@ -1,11 +1,11 @@ - + xmlns:si="http://www.springframework.org/schema/integration" + xmlns:task="http://www.springframework.org/schema/task" + xsi:schemaLocation="http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd + http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/task http://www.springframework.org/schema/task/spring-task.xsd"> @@ -15,6 +15,6 @@ - +