From 32ccd988a0f976aa424623f658a97bf008764876 Mon Sep 17 00:00:00 2001
From: Gary Russell <grussell@vmware.com>
Date: Tue, 12 Feb 2013 16:10:43 -0500
Subject: [PATCH] INT-2929 Fix JMX Occasional Failing Tests

ExponentialMovingAverageRateTests are VERY sensitive to
timing, when running on a busy platform.

Add code to skip the assertions if we detect we are
running on a slow machine.
---
 .../ExponentialMovingAverageRateTests.java    | 45 ++++++++++++++-----
 1 file changed, 35 insertions(+), 10 deletions(-)

diff --git a/spring-integration-jmx/src/test/java/org/springframework/integration/monitor/ExponentialMovingAverageRateTests.java b/spring-integration-jmx/src/test/java/org/springframework/integration/monitor/ExponentialMovingAverageRateTests.java
index 9f4a3361c9..436bc158e3 100644
--- a/spring-integration-jmx/src/test/java/org/springframework/integration/monitor/ExponentialMovingAverageRateTests.java
+++ b/spring-integration-jmx/src/test/java/org/springframework/integration/monitor/ExponentialMovingAverageRateTests.java
@@ -1,11 +1,11 @@
 /*
- * Copyright 2002-2010 the original author or authors.
- * 
+ * Copyright 2002-2013 the original author or authors.
+ *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
- * 
+ *
  * http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
  * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
  * specific language governing permissions and limitations under the License.
@@ -16,16 +16,21 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.junit.Ignore;
 import org.junit.Test;
 
 /**
  * @author Dave Syer
- * 
+ * @author Gary Russell
+ *
  */
 public class ExponentialMovingAverageRateTests {
 
-	private ExponentialMovingAverageRate history = new ExponentialMovingAverageRate(1., 10., 10);
+	private final static Log logger = LogFactory.getLog(ExponentialMovingAverageRateTests.class);
+
+	private final ExponentialMovingAverageRate history = new ExponentialMovingAverageRate(1., 10., 10);
 
 	@Test
 	public void testGetCount() {
@@ -43,23 +48,43 @@ public class ExponentialMovingAverageRateTests {
 
 	@Test
 	public void testGetEarlyMean() throws Exception {
+		long t0 = System.currentTimeMillis();
 		assertEquals(0, history.getMean(), 0.01);
 		Thread.sleep(20L);
 		history.increment();
-		assertTrue(history.getMean() > 10);
+		long elapsed = System.currentTimeMillis() - t0;
+		if (elapsed < 30L) {
+			assertTrue(history.getMean() > 10);
+		}
+		else {
+			logger.warn("Test took too long to verify mean");
+		}
 	}
 
 	@Test
 	public void testGetMean() throws Exception {
+		long t0 = System.currentTimeMillis();
 		assertEquals(0, history.getMean(), 0.01);
 		Thread.sleep(20L);
 		history.increment();
 		Thread.sleep(20L);
 		history.increment();
 		double before = history.getMean();
-		assertTrue(before > 10);
-		Thread.sleep(20L);
-		assertTrue(history.getMean() < before);
+		long elapsed = System.currentTimeMillis() - t0;
+		if (elapsed < 50L) {
+			assertTrue(before > 10);
+			Thread.sleep(20L);
+			elapsed = System.currentTimeMillis() - t0;
+			if (elapsed < 80L) {
+				assertTrue(history.getMean() < before);
+			}
+			else {
+				logger.warn("Test took too long to verify mean");
+			}
+		}
+		else {
+			logger.warn("Test took too long to verify mean");
+		}
 	}
 
 	@Test