Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-9937: Remove logger.error from the TcpSendingMessageHandler

Browse Source 
Fixes: #9937
Issue link: https://github.com/spring-projects/spring-integration/issues/9937

The `TcpSendingMessageHandler` throws exceptions to the caller this or other way.
There is just no reason to have extra `logger.error()` in those cases

(cherry picked from commit fe5b12d98b)
This commit is contained in:
Artem Bilan
2025-04-01 14:08:50 -04:00
committed by Spring Builds
parent 9711fd6160
commit 384bb2bc2c
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/TcpSendingMessageHandler.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2023 the original author or authors. * Copyright 2002-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -90,7 +90,6 @@ public class TcpSendingMessageHandler extends AbstractMessageHandler implements
connection = this.clientConnectionFactory.getConnection(); connection = this.clientConnectionFactory.getConnection();
} }
catch (Exception ex) { catch (Exception ex) {
logger.error(ex, "Error creating connection");
throw new MessageHandlingException(message, "Failed to obtain a connection in the [" + this + ']', ex); throw new MessageHandlingException(message, "Failed to obtain a connection in the [" + this + ']', ex);
} }
return connection; return connection;
@@ -123,7 +122,6 @@ public class TcpSendingMessageHandler extends AbstractMessageHandler implements
connection.send(message); connection.send(message);
} }
catch (Exception ex) { catch (Exception ex) {
logger.error(ex, "Error sending message");
connection.close(); connection.close();
throw IntegrationUtils.wrapInHandlingExceptionIfNecessary(message, throw IntegrationUtils.wrapInHandlingExceptionIfNecessary(message,
() -> "Error sending message in the [" + this + ']', ex); () -> "Error sending message in the [" + this + ']', ex);
@@ -135,7 +133,6 @@ public class TcpSendingMessageHandler extends AbstractMessageHandler implements
} }
} }
else { else {
logger.error(() -> "Unable to find outbound socket for " + message);
MessageHandlingException messageHandlingException = MessageHandlingException messageHandlingException =
new MessageHandlingException(message, "Unable to find outbound socket in the [" + this + ']'); new MessageHandlingException(message, "Unable to find outbound socket in the [" + this + ']');
publishNoConnectionEvent(messageHandlingException, connectionId); publishNoConnectionEvent(messageHandlingException, connectionId);