Checkstyle - Phase I - Unused Imports

I copied the checkstyle config from spring-boot and commented
out most of the rules.

Over time, we should uncomment each rule and fix violations.
This commit is contained in:
Gary Russell
2016-03-04 15:47:08 -05:00
parent 15026062ac
commit 5fe827a3dd
32 changed files with 236 additions and 87 deletions

View File

@@ -0,0 +1,17 @@
^\Q/*\E$
^\Q * Copyright \E20\d\d\-20\d\d\Q the original author or authors.\E$
^\Q *\E$
^\Q * Licensed under the Apache License, Version 2.0 (the "License");\E$
^\Q * you may not use this file except in compliance with the License.\E$
^\Q * You may obtain a copy of the License at\E$
^\Q *\E$
^\Q * http://www.apache.org/licenses/LICENSE-2.0\E$
^\Q *\E$
^\Q * Unless required by applicable law or agreed to in writing, software\E$
^\Q * distributed under the License is distributed on an "AS IS" BASIS,\E$
^\Q * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\E$
^\Q * See the License for the specific language governing permissions and\E$
^\Q * limitations under the License.\E$
^\Q */\E$
^$
^.*$

View File

@@ -0,0 +1,6 @@
<?xml version="1.0"?>
<!DOCTYPE suppressions PUBLIC
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
</suppressions>

View File

@@ -0,0 +1,165 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
<module name="Checker">
<!-- Root Checks -->
<!-- <module name="RegexpHeader"> -->
<!-- <property name="headerFile" value="${checkstyle.header.file}" /> -->
<!-- <property name="fileExtensions" value="java" /> -->
<!-- </module> -->
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="lf"/>
</module>
<!-- TreeWalker Checks -->
<module name="TreeWalker">
<!-- Annotations -->
<!-- <module name="AnnotationUseStyle"> -->
<!-- <property name="elementStyle" value="compact" /> -->
<!-- </module> -->
<!-- <module name="MissingOverride" /> -->
<!-- <module name="PackageAnnotation" /> -->
<!-- <module name="AnnotationLocation"> -->
<!-- <property name="allowSamelineSingleParameterlessAnnotation" -->
<!-- value="false" /> -->
<!-- </module> -->
<!-- Block Checks -->
<!-- <module name="EmptyBlock"> -->
<!-- <property name="option" value="text" /> -->
<!-- </module> -->
<!-- <module name="LeftCurly" /> -->
<!-- <module name="RightCurly"> -->
<!-- <property name="option" value="alone" /> -->
<!-- </module> -->
<!-- <module name="NeedBraces" /> -->
<!-- <module name="AvoidNestedBlocks" /> -->
<!-- Class Design -->
<!-- <module name="FinalClass" /> -->
<!-- <module name="InterfaceIsType" /> -->
<!-- <module name="HideUtilityClassConstructor" /> -->
<!-- <module name="MutableException" /> -->
<!-- <module name="InnerTypeLast" /> -->
<!-- <module name="OneTopLevelClass" /> -->
<!-- Coding -->
<!-- <module name="CovariantEquals" /> -->
<!-- <module name="EmptyStatement" /> -->
<!-- <module name="EqualsHashCode" /> -->
<!-- <module name="InnerAssignment" /> -->
<!-- <module name="SimplifyBooleanExpression" /> -->
<!-- <module name="SimplifyBooleanReturn" /> -->
<!-- <module name="StringLiteralEquality" /> -->
<!-- <module name="NestedForDepth"> -->
<!-- <property name="max" value="3" /> -->
<!-- </module> -->
<!-- <module name="NestedIfDepth"> -->
<!-- <property name="max" value="3" /> -->
<!-- </module> -->
<!-- <module name="NestedTryDepth"> -->
<!-- <property name="max" value="3" /> -->
<!-- </module> -->
<!-- <module name="MultipleVariableDeclarations" /> -->
<!-- <module name="RequireThis"> -->
<!-- <property name="checkMethods" value="false" /> -->
<!-- </module> -->
<!-- <module name="OneStatementPerLine" /> -->
<!-- Imports -->
<!-- <module name="AvoidStarImport" /> -->
<!-- <module name="AvoidStaticImport"> -->
<!-- <property name="excludes" -->
<!-- value="org.assertj.core.api.Assertions.*, org.junit.Assert.*, org.junit.Assume.*, org.junit.internal.matchers.ThrowableMessageMatcher.*, org.hamcrest.CoreMatchers.*, org.hamcrest.Matchers.*, org.springframework.boot.configurationprocessor.ConfigurationMetadataMatchers.*, org.springframework.boot.configurationprocessor.TestCompiler.*, org.mockito.Mockito.*, org.mockito.BDDMockito.*, org.mockito.Matchers.*, org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*, org.springframework.test.web.servlet.result.MockMvcResultMatchers.*, org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors.*, org.springframework.security.test.web.servlet.setup.SecurityMockMvcConfigurers.*, org.springframework.hateoas.mvc.ControllerLinkBuilder.linkTo" /> -->
<!-- </module> -->
<!-- <module name="IllegalImport" /> -->
<!-- <module name="RedundantImport" /> -->
<module name="UnusedImports">
<property name="processJavadoc" value="true" />
</module>
<!-- <module name="ImportOrder"> -->
<!-- <property name="groups" value="java,/^javax?\./,*,org.springframework" /> -->
<!-- <property name="ordered" value="true" /> -->
<!-- <property name="separated" value="true" /> -->
<!-- <property name="option" value="bottom" /> -->
<!-- <property name="sortStaticImportsAlphabetically" value="true" /> -->
<!-- </module> -->
<!-- Javadoc Comments -->
<!-- <module name="JavadocType"> -->
<!-- <property name="scope" value="package"/> -->
<!-- <property name="authorFormat" value=".+\s.+"/> -->
<!-- </module> -->
<!-- <module name="JavadocMethod"> -->
<!-- <property name="allowMissingJavadoc" value="true" /> -->
<!-- </module> -->
<!-- <module name="JavadocVariable"> -->
<!-- <property name="scope" value="public"/> -->
<!-- </module> -->
<!-- <module name="JavadocStyle"> -->
<!-- <property name="checkEmptyJavadoc" value="true"/> -->
<!-- </module> -->
<!-- <module name="NonEmptyAtclauseDescription" /> -->
<!-- <module name="JavadocTagContinuationIndentation"> -->
<!-- <property name="offset" value="0"/> -->
<!-- </module> -->
<!-- <module name="AtclauseOrder"> -->
<!-- <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF"/> -->
<!-- <property name="tagOrder" value="@param, @author, @since, @see, @version, @serial, @deprecated"/> -->
<!-- </module> -->
<!-- <module name="AtclauseOrder"> -->
<!-- <property name="target" value="METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/> -->
<!-- <property name="tagOrder" value="@param, @return, @throws, @since, @deprecated, @see"/> -->
<!-- </module> -->
<!-- Miscellaneous -->
<!-- <module name="CommentsIndentation" /> -->
<!-- <module name="UpperEll" /> -->
<!-- <module name="ArrayTypeStyle" /> -->
<!-- <module name="OuterTypeFilename" /> -->
<!-- Modifiers -->
<!-- <module name="RedundantModifier" /> -->
<!-- Regexp -->
<!-- <module name="RegexpSinglelineJava"> -->
<!-- <property name="format" value="^\t* +\t*\S" /> -->
<!-- <property name="message" -->
<!-- value="Line has leading space characters; indentation should be performed with tabs only." /> -->
<!-- <property name="ignoreComments" value="true" /> -->
<!-- </module> -->
<!-- <module name="RegexpSinglelineJava"> -->
<!-- <property name="maximum" value="0"/> -->
<!-- <property name="format" value="org\.mockito\.Mockito\.(when|doThrow|doAnswer)" /> -->
<!-- <property name="message" -->
<!-- value="Please use BDDMockto imports." /> -->
<!-- <property name="ignoreComments" value="true" /> -->
<!-- </module> -->
<!-- <module name="RegexpSinglelineJava"> -->
<!-- <property name="maximum" value="0"/> -->
<!-- <property name="format" value="org\.junit\.Assert\.assert" /> -->
<!-- <property name="message" -->
<!-- value="Please use AssertJ imports." /> -->
<!-- <property name="ignoreComments" value="true" /> -->
<!-- </module> -->
<!-- <module name="Regexp"> -->
<!-- <property name="format" value="[ \t]+$" /> -->
<!-- <property name="illegalPattern" value="true" /> -->
<!-- <property name="message" value="Trailing whitespace" /> -->
<!-- </module> -->
<!-- Whitespace -->
<!-- <module name="GenericWhitespace" /> -->
<!-- <module name="MethodParamPad" /> -->
<!-- <module name="NoWhitespaceAfter" > -->
<!-- <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS, ARRAY_DECLARATOR"/> -->
<!-- </module> -->
<!-- <module name="NoWhitespaceBefore" /> -->
<!-- <module name="ParenPad" /> -->
<!-- <module name="TypecastParenPad" /> -->
<!-- <module name="WhitespaceAfter" /> -->
<!-- <module name="WhitespaceAround" /> -->
</module>
</module>