From 6bcf71c8638fdae34f007c112364353a0449eeae Mon Sep 17 00:00:00 2001 From: Artem Bilan Date: Sat, 18 May 2019 09:13:05 -0400 Subject: [PATCH] Fix Sonar smell in the RSocketInboundGatewayParser --- .../config/RSocketInboundGatewayParser.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/spring-integration-rsocket/src/main/java/org/springframework/integration/rsocket/config/RSocketInboundGatewayParser.java b/spring-integration-rsocket/src/main/java/org/springframework/integration/rsocket/config/RSocketInboundGatewayParser.java index 009385fe99..92d0f832b0 100644 --- a/spring-integration-rsocket/src/main/java/org/springframework/integration/rsocket/config/RSocketInboundGatewayParser.java +++ b/spring-integration-rsocket/src/main/java/org/springframework/integration/rsocket/config/RSocketInboundGatewayParser.java @@ -16,6 +16,9 @@ package org.springframework.integration.rsocket.config; +import java.util.Arrays; +import java.util.List; + import org.w3c.dom.Element; import org.springframework.beans.factory.support.BeanDefinitionBuilder; @@ -31,6 +34,12 @@ import org.springframework.integration.rsocket.inbound.RSocketInboundGateway; */ public class RSocketInboundGatewayParser extends AbstractInboundGatewayParser { + private static final List NON_ELIGIBLE_ATTRIBUTES = + Arrays.asList("path", + "rsocket-strategies", + "rsocket-connector", + "request-element-type"); + @Override protected Class getBeanClass(Element element) { return RSocketInboundGateway.class; @@ -38,11 +47,7 @@ public class RSocketInboundGatewayParser extends AbstractInboundGatewayParser { @Override protected boolean isEligibleAttribute(String attributeName) { - return !attributeName.equals("path") - && !attributeName.equals("rsocket-strategies") - && !attributeName.equals("rsocket-connector") - && !attributeName.equals("request-element-type") - && super.isEligibleAttribute(attributeName); + return !NON_ELIGIBLE_ATTRIBUTES.contains(attributeName) && super.isEligibleAttribute(attributeName); } @Override