Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ThreadAffinityClientConnectionFactory

Browse Source 
`isSingleUse()` should return `false` by default - the whole point is
to bind a connection to a thread. The TACCF should have its own flag
not return the delegate's.

Also, the `TcpReceivingChanneladapter` calls `closeConnection(connectionId)`.
This should be a no-op for the TACCF since the proper way to close a connection
is to call `releaseConnection()` on the thread to which the connection is bound.

**cherry-pick to 5.0.x**
This commit is contained in:
Gary Russell
2018-07-06 15:38:00 -04:00
committed by Artem Bilan
parent d4b7cef928
commit 753255c30c
1 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/ThreadAffinityClientConnectionFactory.java
View File

@@ -298,21 +298,6 @@ public class ThreadAffinityClientConnectionFactory extends AbstractClientConnect
this.connectionFactory.setMapper(mapper);
}
@Override
public boolean isSingleUse() {
return this.connectionFactory.isSingleUse();
}
@Override
public void setSingleUse(boolean singleUse) {
this.connectionFactory.setSingleUse(singleUse);
}
@Override
public void setLeaveOpen(boolean leaveOpen) {
this.connectionFactory.setLeaveOpen(leaveOpen);
}
@Override
public void setInterceptorFactoryChain(TcpConnectionInterceptorFactoryChain interceptorFactoryChain) {
this.connectionFactory.setInterceptorFactoryChain(interceptorFactoryChain);
@@ -370,7 +355,7 @@ public class ThreadAffinityClientConnectionFactory extends AbstractClientConnect
@Override
public boolean closeConnection(String connectionId) {
return this.connectionFactory.closeConnection(connectionId);
return false;
}
@Override