INT-3950: Fix Aggregator documentation
JIRA: https://jira.spring.io/browse/INT-3950 Previously there was a mention of the `MessageGroupStore.expireMessageGroup(groupId)` which just doesn't existing in the Framework and never has been there. * Fix the documentation for the existing `MessageGroupStore.expireMessageGroups(timeout)`. Although the mention there of `Control Bus` requires to have `@ManagedOperation` on the method. * Add `@ManagedOperation` for the `MessageGroupStore.expireMessageGroups(timeout)` and confirm with the test-case: `AggregatorWithMessageStoreParserTests` * Fix the same docs in the XSD for `<aggregator>` * Fix other typos in the `aggregator.adoc` and `resequencer.adoc`
This commit is contained in:
@@ -26,6 +26,7 @@ import org.springframework.integration.support.DefaultMessageBuilderFactory;
|
||||
import org.springframework.integration.support.MessageBuilderFactory;
|
||||
import org.springframework.integration.support.utils.IntegrationUtils;
|
||||
import org.springframework.jmx.export.annotation.ManagedAttribute;
|
||||
import org.springframework.jmx.export.annotation.ManagedOperation;
|
||||
import org.springframework.jmx.export.annotation.ManagedResource;
|
||||
import org.springframework.messaging.Message;
|
||||
|
||||
@@ -107,6 +108,7 @@ public abstract class AbstractMessageGroupStore extends AbstractBatchingMessageG
|
||||
}
|
||||
|
||||
@Override
|
||||
@ManagedOperation
|
||||
public synchronized int expireMessageGroups(long timeout) {
|
||||
int count = 0;
|
||||
long threshold = System.currentTimeMillis() - timeout;
|
||||
|
||||
@@ -17,6 +17,7 @@ import java.util.Collection;
|
||||
import java.util.Iterator;
|
||||
|
||||
import org.springframework.jmx.export.annotation.ManagedAttribute;
|
||||
import org.springframework.jmx.export.annotation.ManagedOperation;
|
||||
import org.springframework.messaging.Message;
|
||||
|
||||
/**
|
||||
@@ -101,6 +102,7 @@ public interface MessageGroupStore extends BasicMessageGroupStore {
|
||||
*
|
||||
* @see #registerMessageGroupExpiryCallback(MessageGroupCallback)
|
||||
*/
|
||||
@ManagedOperation
|
||||
int expireMessageGroups(long timeout);
|
||||
|
||||
/**
|
||||
@@ -145,7 +147,7 @@ public interface MessageGroupStore extends BasicMessageGroupStore {
|
||||
/**
|
||||
* Invoked when a MessageGroupStore expires a group.
|
||||
*/
|
||||
public interface MessageGroupCallback {
|
||||
interface MessageGroupCallback {
|
||||
|
||||
void execute(MessageGroupStore messageGroupStore, MessageGroup group);
|
||||
|
||||
|
||||
@@ -3739,7 +3739,7 @@
|
||||
Specifies whether messages that expired should be aggregated and sent to the 'output-channel' or 'replyChannel'.
|
||||
Messages are expired when their containing MessageGroup expires. One of the ways of expiring MessageGroups is by
|
||||
configuring a MessageGroupStoreReaper. However MessageGroups can alternatively be expired by simply calling
|
||||
MessageGroupStore.expireMessageGroup(groupId). That could be accomplished via a ControlBus operation
|
||||
MessageGroupStore.expireMessageGroups(timeout). That could be accomplished via a ControlBus operation
|
||||
or by simply invoking that method if you have a reference to the MessageGroupStore instance.
|
||||
</xsd:documentation>
|
||||
</xsd:annotation>
|
||||
|
||||
@@ -14,10 +14,12 @@
|
||||
|
||||
<aggregator id="aggregator" ref="aggregatorBean"
|
||||
input-channel="input" output-channel="output" message-store="messageStore" send-partial-result-on-expiry="true"/>
|
||||
|
||||
|
||||
<beans:bean id="messageStore" class="org.springframework.integration.store.SimpleMessageStore"/>
|
||||
|
||||
<beans:bean id="aggregatorBean"
|
||||
class="org.springframework.integration.config.TestAggregatorBean" />
|
||||
|
||||
<control-bus input-channel="controlBusChannel" output-channel="nullChannel"/>
|
||||
|
||||
</beans:beans>
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2010 the original author or authors.
|
||||
* Copyright 2002-2016 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -26,31 +26,36 @@ import org.springframework.messaging.Message;
|
||||
import org.springframework.messaging.MessageChannel;
|
||||
import org.springframework.integration.store.MessageGroupStore;
|
||||
import org.springframework.integration.support.MessageBuilder;
|
||||
import org.springframework.messaging.support.GenericMessage;
|
||||
import org.springframework.test.annotation.DirtiesContext;
|
||||
import org.springframework.test.context.ContextConfiguration;
|
||||
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
|
||||
|
||||
/**
|
||||
* @author Dave Syer
|
||||
* @author Artem Bilan
|
||||
*/
|
||||
@ContextConfiguration
|
||||
@RunWith(SpringJUnit4ClassRunner.class)
|
||||
@DirtiesContext
|
||||
public class AggregatorWithMessageStoreParserTests {
|
||||
|
||||
|
||||
@Autowired
|
||||
@Qualifier("input")
|
||||
private MessageChannel input;
|
||||
|
||||
|
||||
@Autowired
|
||||
private TestAggregatorBean aggregatorBean;
|
||||
|
||||
|
||||
@Autowired
|
||||
private MessageGroupStore messageGroupStore;
|
||||
|
||||
@Autowired
|
||||
private MessageChannel controlBusChannel;
|
||||
|
||||
@Test
|
||||
@DirtiesContext
|
||||
public void testAggregation() {
|
||||
|
||||
input.send(createMessage("123", "id1", 3, 1, null));
|
||||
assertEquals(1, messageGroupStore.getMessageGroup("id1").size());
|
||||
input.send(createMessage("789", "id1", 3, 3, null));
|
||||
@@ -67,12 +72,11 @@ public class AggregatorWithMessageStoreParserTests {
|
||||
@Test
|
||||
@DirtiesContext
|
||||
public void testExpiry() {
|
||||
|
||||
input.send(createMessage("123", "id1", 3, 1, null));
|
||||
assertEquals(1, messageGroupStore.getMessageGroup("id1").size());
|
||||
input.send(createMessage("456", "id1", 3, 2, null));
|
||||
assertEquals(2, messageGroupStore.getMessageGroup("id1").size());
|
||||
messageGroupStore.expireMessageGroups(-10000);
|
||||
this.controlBusChannel.send(new GenericMessage<Object>("@messageStore.expireMessageGroups(-10000)"));
|
||||
assertEquals("One and only one message should have been aggregated", 1, aggregatorBean
|
||||
.getAggregatedMessages().size());
|
||||
Message<?> aggregatedMessage = aggregatorBean.getAggregatedMessages().get("id1");
|
||||
|
||||
Reference in New Issue
Block a user