Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

INT-1475, addressed the issue. Made 'should-delete-messages' required by the schema and added tests to validate it. Added more tests for Pop3MailReceiever. Modified documentation to explain the change and reasoning behind the change

Browse Source
This commit is contained in:
Oleg Zhurakousky
2010-09-23 20:43:44 -04:00
parent c521fc9531
commit 76fc874be4
7 changed files with 106 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-integration-mail/src/main/java/org/springframework/integration/mail/AbstractMailReceiver.java
View File

@@ -60,7 +60,7 @@ public abstract class AbstractMailReceiver extends IntegrationObjectSupport impl
private volatile Folder folder;
private volatile boolean shouldDeleteMessages = false;
private volatile boolean shouldDeleteMessages;
protected volatile int folderOpenMode = Folder.READ_ONLY;
@@ -80,13 +80,13 @@ public abstract class AbstractMailReceiver extends IntegrationObjectSupport impl
public AbstractMailReceiver(URLName urlName) {
Assert.notNull(urlName, "urlName must not be null");
this.url = urlName;
this.shouldDeleteMessages = urlName.getProtocol().startsWith("pop3");
//this.shouldDeleteMessages = urlName.getProtocol().startsWith("pop3");
}
public AbstractMailReceiver(String url) {
if (url != null) {
this.url = new URLName(url);
this.shouldDeleteMessages = this.url.getProtocol().startsWith("pop3");
//this.shouldDeleteMessages = this.url.getProtocol().startsWith("pop3");
}
else {
this.url = null;

2
spring-integration-mail/src/main/resources/org/springframework/integration/mail/config/spring-integration-mail-2.0.xsd
View File

@@ -188,7 +188,7 @@
]]></xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="should-delete-messages" type="xsd:string" use="optional" default="false">
<xsd:attribute name="should-delete-messages" type="xsd:string" use="required">
<xsd:annotation>
<xsd:documentation><![CDATA[
Specify whether mail messages should be deleted after retrieval.