From 8a29c1e60bc186b8fced4abed7e6b73d45db9416 Mon Sep 17 00:00:00 2001
From: Vladislav Fefelov <fvlad42@gmail.com>
Date: Thu, 15 Jun 2023 12:28:51 +0200
Subject: [PATCH] Optimise `maybeIndex()` in `JsonPropertyAccessor`

The `NumberFormatException` flow control is costly
operation

* Use `Character.isDigit()` check iterating through property String
instead of `NumberFormatException` flow control

**Cherry-pick to `6.1.x`, `6.0.x` & `5.5.x`**
---
 .../json/JsonPropertyAccessor.java            | 23 ++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/spring-integration-core/src/main/java/org/springframework/integration/json/JsonPropertyAccessor.java b/spring-integration-core/src/main/java/org/springframework/integration/json/JsonPropertyAccessor.java
index 36192d337b..966e3cc719 100644
--- a/spring-integration-core/src/main/java/org/springframework/integration/json/JsonPropertyAccessor.java
+++ b/spring-integration-core/src/main/java/org/springframework/integration/json/JsonPropertyAccessor.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2022 the original author or authors.
+ * Copyright 2013-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,6 +31,7 @@ import org.springframework.expression.PropertyAccessor;
 import org.springframework.expression.TypedValue;
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
+import org.springframework.util.StringUtils;
 
 /**
  * A SpEL {@link PropertyAccessor} that knows how to read properties from JSON objects.
@@ -41,6 +42,7 @@ import org.springframework.util.Assert;
  * @author Paul Martin
  * @author Gary Russell
  * @author Pierre Lakreb
+ * @author Vladislav Fefelov
  *
  * @since 3.0
  */
@@ -109,6 +111,9 @@ public class JsonPropertyAccessor implements PropertyAccessor {
 	 * Return an integer if the String property name can be parsed as an int, or null otherwise.
 	 */
 	private static Integer maybeIndex(String name) {
+		if (!isNumeric(name)) {
+			return null;
+		}
 		try {
 			return Integer.valueOf(name);
 		}
@@ -139,6 +144,22 @@ public class JsonPropertyAccessor implements PropertyAccessor {
 		throw new UnsupportedOperationException("Write is not supported");
 	}
 
+	/**
+	 * Check if the string is a numeric representation (all digits) or not.
+	 */
+	private static boolean isNumeric(String str) {
+		if (!StringUtils.hasLength(str)) {
+			return false;
+		}
+		int length = str.length();
+		for (int i = 0; i < length; i++) {
+			if (!Character.isDigit(str.charAt(i))) {
+				return false;
+			}
+		}
+		return true;
+	}
+
 	private static TypedValue typedValue(JsonNode json) throws AccessException {
 		if (json == null) {
 			return TypedValue.NULL;