Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Sonar smells for HTTP & WebFlux modules (#2810)

Browse Source 
* Fix Sonar smells for HTTP & WebFlux modules

* * Fix more HTTP Sonar smells

* * Remove unused import
* Fix complexity in the `IntegrationMBeanExporter.enhanceSourceMonitor()`

* * Remove unused `IntegrationMBeanExporter.getField()` method

* * Remove unused import in the `IntegrationMBeanExporter`
This commit is contained in:
Artem Bilan
2019-03-18 10:08:37 -04:00
committed by Gary Russell
parent 3751505823
commit 8f86ef918c
7 changed files with 194 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-integration-http/src/test/java/org/springframework/integration/http/inbound/HttpRequestHandlingMessagingGatewayWithPathMappingTests.java
View File

@@ -82,7 +82,7 @@ public class HttpRequestHandlingMessagingGatewayWithPathMappingTests extends Abs
RequestEntity<Object> httpEntity = prepareRequestEntity(body, new ServletServerHttpRequest(request));
Object result = gateway.doHandleRequest(request, httpEntity, response);
Object result = gateway.doHandleRequest(request, httpEntity);
assertThat(result).isInstanceOf(Message.class);
assertThat(((Message<?>) result).getPayload()).isEqualTo("hello");
@@ -96,8 +96,6 @@ public class HttpRequestHandlingMessagingGatewayWithPathMappingTests extends Abs
replyChannel.send(message);
});
MockHttpServletRequest request = new MockHttpServletRequest();
MockHttpServletResponse response = new MockHttpServletResponse();
request.setMethod("POST");
request.setContentType("text/plain");
request.setParameter("foo", "bar");
@@ -127,7 +125,7 @@ public class HttpRequestHandlingMessagingGatewayWithPathMappingTests extends Abs
RequestEntity<Object> httpEntity = prepareRequestEntity(body, new ServletServerHttpRequest(request));
Object result = gateway.doHandleRequest(request, httpEntity, response);
Object result = gateway.doHandleRequest(request, httpEntity);
assertThat(result).isInstanceOf(Message.class);
assertThat(((Message<?>) result).getPayload()).isEqualTo("bill");
}
@@ -173,12 +171,12 @@ public class HttpRequestHandlingMessagingGatewayWithPathMappingTests extends Abs
RequestEntity<Object> httpEntity = prepareRequestEntity(body, new ServletServerHttpRequest(request));
Object result = gateway.doHandleRequest(request, httpEntity, response);
Object result = gateway.doHandleRequest(request, httpEntity);
assertThat(result).isInstanceOf(Message.class);
assertThat(((Map<String, Object>) ((Message<?>) result).getPayload()).get("f")).isEqualTo("bill");
}
private static RequestEntity<Object> prepareRequestEntity(Object body, ServletServerHttpRequest request) throws IOException {
private static RequestEntity<Object> prepareRequestEntity(Object body, ServletServerHttpRequest request) {
return new RequestEntity<>(body, request.getHeaders(), request.getMethod(), request.getURI());
}