From 91c6e16945999a78ae12b941f2b1b45c8eb2cda3 Mon Sep 17 00:00:00 2001 From: abilan Date: Thu, 1 Dec 2022 14:46:09 -0500 Subject: [PATCH] Improve `DelayerUsageTests` The time-based tests are very sensitive to an activity on the target machine. So, strict test sometimes fail. * Fix `DelayerUsageTests` to deal with approximate values to compare by some percentage --- .../integration/config/xml/DelayerUsageTests.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-integration-core/src/test/java/org/springframework/integration/config/xml/DelayerUsageTests.java b/spring-integration-core/src/test/java/org/springframework/integration/config/xml/DelayerUsageTests.java index 79fe3e0dd9..5c7e7187f8 100644 --- a/spring-integration-core/src/test/java/org/springframework/integration/config/xml/DelayerUsageTests.java +++ b/spring-integration-core/src/test/java/org/springframework/integration/config/xml/DelayerUsageTests.java @@ -80,7 +80,7 @@ public class DelayerUsageTests { }); assertThat(outputA.receive(10000)).isNotNull(); - assertThat(System.currentTimeMillis() - start).isGreaterThanOrEqualTo(1000); + assertThat(System.currentTimeMillis() - start).isCloseTo(1000, withinPercentage(10)); } @Test @@ -124,17 +124,17 @@ public class DelayerUsageTests { delayerInsideChain.send(new GenericMessage<>("Hello")); Message message = outputA.receive(10000); assertThat(message).isNotNull(); - assertThat(System.currentTimeMillis() - start).isGreaterThanOrEqualTo(1000); + assertThat(System.currentTimeMillis() - start).isCloseTo(1000, withinPercentage(10)); assertThat(message.getPayload()).isEqualTo("hello"); } @Test - public void testInt2243DelayerExpression() { + public void delayEvaluatedFromExpression() { long start = System.currentTimeMillis(); this.inputC.send(new GenericMessage<>("test")); Message message = this.outputC.receive(10000); assertThat(message).isNotNull(); - assertThat(System.currentTimeMillis() - start).isGreaterThanOrEqualTo(1000); + assertThat(System.currentTimeMillis() - start).isCloseTo(1000, withinPercentage(10)); assertThat(message.getPayload()).isEqualTo("test"); }