Enable ModifierOrderCheck Checkstyle rule (#2673)

* Enable ModifierOrderCheck Checkstyle rule

* Fix violations for `static` and `abstract` modifier
* Remove redundant code in the `TcpNioConnection`
* Mark `connectionFactoryName` as `@Nullable` in the `TcpConnectionSupport`
ctor and its inheritors
* Fix some smells according IDEA suggestions in the affected classes
* This should fix some Sonar smells as well

* * Fix `HeaderMapperTests`

* * Polishing `TcpConnection` code style and fix Javdocs
This commit is contained in:
Artem Bilan
2018-12-20 19:19:47 -05:00
committed by Gary Russell
parent a01d09f0f1
commit 93d7c58b64
56 changed files with 633 additions and 563 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,49 +23,51 @@ import com.jcraft.jsch.Logger;
/**
* @author Oleg Zhurakousky
* @author Artem Bilan
*
* @since 2.0.1
*/
class JschLogger implements Logger {
private final static Log logger = LogFactory.getLog("com.jcraft.jsch");
private static final Log logger = LogFactory.getLog("com.jcraft.jsch");
public boolean isEnabled(int level) {
switch (level) {
case Logger.INFO:
return logger.isInfoEnabled();
case Logger.WARN:
return logger.isWarnEnabled();
case Logger.DEBUG:
return logger.isDebugEnabled();
case Logger.ERROR:
return logger.isErrorEnabled();
case Logger.FATAL:
return logger.isFatalEnabled();
default:
return false;
case Logger.INFO:
return logger.isInfoEnabled();
case Logger.WARN:
return logger.isWarnEnabled();
case Logger.DEBUG:
return logger.isDebugEnabled();
case Logger.ERROR:
return logger.isErrorEnabled();
case Logger.FATAL:
return logger.isFatalEnabled();
default:
return false;
}
}
public void log(int level, String message) {
switch (level) {
case Logger.INFO:
logger.info(message);
break;
case Logger.WARN:
logger.warn(message);
break;
case Logger.DEBUG:
logger.debug(message);
break;
case Logger.ERROR:
logger.error(message);
break;
case Logger.FATAL:
logger.fatal(message);
break;
default:
break;
case Logger.INFO:
logger.info(message);
break;
case Logger.WARN:
logger.warn(message);
break;
case Logger.DEBUG:
logger.debug(message);
break;
case Logger.ERROR:
logger.error(message);
break;
case Logger.FATAL:
logger.fatal(message);
break;
default:
break;
}
}
}