Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

INT-958: change meaning of timeout parameter in MessageGroupStore

Browse Source
This commit is contained in:
David Syer
2010-05-05 11:10:54 +00:00
parent 396da3c09a
commit 9b6d5720f8
7 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
org.springframework.integration/src/main/java/org/springframework/integration/store/MessageGroupStore.java
View File

@@ -66,14 +66,16 @@ public interface MessageGroupStore {
void registerExpiryCallback(MessageGroupCallback callback);
/**
* Extract all expired groups (those whose timestamp is less than the threshold provided) and call each of the
* registered callbacks on them in turn.
* Extract all expired groups (whose timestamp is older than the current time less the threshold provided) and call
* each of the registered callbacks on them in turn. For example: call with a timeout of 100 to expire all groups
* that were created more than 100 milliseconds ago, and are not yet complete. Use a timeout of 0 (or negative to be
* on the safe side) to expire all message groups.
*
* @param timestamp the timestamp threshold to use
* @param timeout the timeout threshold to use
* @return the number of message groups expired
*
* @see #registerExpiryCallback(MessageGroupCallback)
*/
int expireMessageGroups(long timestamp);
int expireMessageGroups(long timeout);
}

5
org.springframework.integration/src/main/java/org/springframework/integration/store/SimpleMessageStore.java
View File

@@ -114,10 +114,11 @@ public class SimpleMessageStore implements MessageStore, MessageGroupStore {
expiryCallbacks.add(callback);
}
public int expireMessageGroups(long timestamp) {
public int expireMessageGroups(long timeout) {
int count = 0;
long threshold = System.currentTimeMillis() - timeout;
for (MessageGroup group : correlationToMessageGroup.values()) {
if (group.getTimestamp() < timestamp) {
if (group.getTimestamp() < threshold) {
count++;
expire(group);
removeMessageGroup(group.getCorrelationKey());