Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-3549: Fix minor SonarQube smells

Browse Source 
Fixes https://github.com/spring-projects/spring-integration/issues/3549
This commit is contained in:
trungPa
2021-07-23 22:07:39 +07:00
committed by GitHub
parent bc8246d267
commit 9e512186ed
33 changed files with 77 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spring-integration-syslog/src/main/java/org/springframework/integration/syslog/RFC5424SyslogParser.java
View File

@@ -99,8 +99,8 @@ public class RFC5424SyslogParser {
message = "";
}
int severity = pri & 0x7;
int facility = pri >> 3;
int severity = pri & 0x7; // NOSONAR magic number
int facility = pri >> 3; // NOSONAR magic number
map.put(SyslogHeaders.FACILITY, facility);
map.put(SyslogHeaders.SEVERITY, severity);
map.put(SyslogHeaders.SEVERITY_TEXT, Severity.parseInt(severity).label());
@@ -239,7 +239,7 @@ public class RFC5424SyslogParser {
public int readInt() {
int val = 0;
while (isDigit()) {
val = (val * 10) + getInt();
val = (val * 10) + getInt(); // NOSONAR magic number
}
return val;
}
@@ -248,8 +248,8 @@ public class RFC5424SyslogParser {
int val = 0;
int order = 0;
while (isDigit()) {
val = (val * 10) + getInt();
order *= 10;
val = (val * 10) + getInt(); // NOSONAR magic number
order *= 10; // NOSONAR magic number
}
return (double) val / order;
@@ -289,7 +289,7 @@ public class RFC5424SyslogParser {
int c;
while (true) {
c = getc();
if (c >= 33 && c <= 127) {
if (c >= 33 && c <= 127) { // NOSONAR magic number
sb.append((char) c);
}
else {
@@ -339,19 +339,19 @@ public class RFC5424SyslogParser {
}
public static Severity parseInt(int syslogSeverity) {
if (syslogSeverity == 7) {
if (syslogSeverity == 7) { // NOSONAR magic number
return DEBUG;
}
if (syslogSeverity == 6) {
if (syslogSeverity == 6) { // NOSONAR magic number
return INFO;
}
if (syslogSeverity == 5) {
if (syslogSeverity == 5) { // NOSONAR magic number
return NOTICE;
}
if (syslogSeverity == 4) {
if (syslogSeverity == 4) { // NOSONAR magic number
return WARN;
}
if (syslogSeverity == 3) {
if (syslogSeverity == 3) { // NOSONAR magic number
return ERROR;
}
if (syslogSeverity == 2) {

6
spring-integration-syslog/src/main/java/org/springframework/integration/syslog/inbound/RFC6587SyslogDeserializer.java
View File

@@ -101,14 +101,14 @@ public class RFC6587SyslogDeserializer implements Deserializer<Map<String, ?>> {
}
private boolean isDigit(int peek) {
return peek >= 0x30 && peek <= 0x39;
return peek >= 0x30 && peek <= 0x39; // NOSONAR magic number
}
private int calculateLength(DataInputStream stream, int peek) throws IOException {
int length = peek & 0xf;
int length = peek & 0xf; // NOSONAR magic number
int c = stream.read();
while (isDigit(c)) {
length = length * 10 + (c & 0xf);
length = length * 10 + (c & 0xf); // NOSONAR magic number
c = stream.read();
}
return length;