Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TcpCodecs factory improvement

Browse Source 
- add convenience factory methods to set the max message size while creating the codec

* Polishing - PR comments; deprecate protected field; checkstyle fixes.
This commit is contained in:
Gary Russell
2019-01-11 12:12:43 -05:00
committed by Artem Bilan
parent 60be204b4d
commit ae3bb154fa
9 changed files with 181 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/serializer/TcpCodecsTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2016 the original author or authors.
* Copyright 2016-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
package org.springframework.integration.ip.tcp.serializer;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.instanceOf;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
@@ -64,4 +65,36 @@ public class TcpCodecsTests {
assertEquals(4, TestUtils.getPropertyValue(codec, "headerSize"));
}
@Test
public void testMaxLengths() {
AbstractByteArraySerializer codec = TcpCodecs.crlf(123);
assertThat(codec, instanceOf(ByteArrayCrLfSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
codec = TcpCodecs.lf(123);
assertThat(codec, instanceOf(ByteArrayLfSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
codec = TcpCodecs.raw(123);
assertThat(codec, instanceOf(ByteArrayRawSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
codec = TcpCodecs.stxetx(123);
assertThat(codec, instanceOf(ByteArrayStxEtxSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
codec = TcpCodecs.singleTerminator((byte) 23, 123);
assertThat(codec, instanceOf(ByteArraySingleTerminatorSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
assertEquals((byte) 23, TestUtils.getPropertyValue(codec, "terminator"));
codec = TcpCodecs.lengthHeader1(123);
assertThat(codec, instanceOf(ByteArrayLengthHeaderSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
assertEquals(1, TestUtils.getPropertyValue(codec, "headerSize"));
codec = TcpCodecs.lengthHeader2(123);
assertThat(codec, instanceOf(ByteArrayLengthHeaderSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
assertEquals(2, TestUtils.getPropertyValue(codec, "headerSize"));
codec = TcpCodecs.lengthHeader4(123);
assertThat(codec, instanceOf(ByteArrayLengthHeaderSerializer.class));
assertThat(codec.getMaxMessageSize(), equalTo(123));
assertEquals(4, TestUtils.getPropertyValue(codec, "headerSize"));
}
}