Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

INT-4018: Resolve some TODOs

Browse Source 
JIRA: https://jira.spring.io/browse/INT-4018

* Resolve some TODOs as expected
* Remove some as logically or physically with useless effort
* Leave others for future considerations
This commit is contained in:
Artem Bilan
2017-03-07 18:17:27 -05:00
committed by Gary Russell
parent 55e7752079
commit b3f461e139
7 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-integration-core/src/test/java/org/springframework/integration/aggregator/MethodInvokingReleaseStrategyTests.java
View File

@@ -178,7 +178,6 @@ public class MethodInvokingReleaseStrategyTests {
return false;
}
}
// TODO: this is stupid, but maybe it should be illegal?
new MethodInvokingReleaseStrategy(new TestReleaseStrategy(), "notEnoughParameters");
}
@@ -190,7 +189,6 @@ public class MethodInvokingReleaseStrategyTests {
return false;
}
}
// TODO: this is stupid, but maybe it should be illegal?
new MethodInvokingReleaseStrategy(new TestReleaseStrategy(), TestReleaseStrategy.class.getMethod(
"notEnoughParameters"));
}
@@ -208,7 +206,6 @@ public class MethodInvokingReleaseStrategyTests {
Assert.assertTrue(adapter.canRelease(messages));
}
// TODO: should this be MessageHandlingException?
@Test(expected = ConversionFailedException.class)
public void testWrongReturnType() throws SecurityException, NoSuchMethodError {
class TestReleaseStrategy {
@@ -248,7 +245,6 @@ public class MethodInvokingReleaseStrategyTests {
Assert.assertTrue(adapter.canRelease(messages));
}
// TODO: review exception type here
@Test(expected = IllegalStateException.class)
public void testWrongReturnTypeUsingMethodObject() throws SecurityException, NoSuchMethodException {
class TestReleaseStrategy {