From b6bd83d548ced9b0fd51dc2334da320e2aabcc62 Mon Sep 17 00:00:00 2001 From: Artem Bilan Date: Wed, 25 Mar 2020 12:51:00 -0400 Subject: [PATCH] Fix deprecation for TX; fix JMS tests; Moore-SR6 * Upgrade to Spring Data Moore-SR6 * Fix `TransactionHandleMessageAdvice` and `TransactionInterceptorBuilder` for deprecations in the `TransactionInterceptor` * Fix `TransactionHandleMessageAdvice` and `TransactionInterceptorBuilder` consumers to expose new `TransactionManager`-based options and deprecate `PlatformTransactionManager`-based * Fix failing JMS tests to reuse an ActiveMQ Connection Factory with a `trustedPackaged(*)` **Cherry-pick to master** # Conflicts: # build.gradle # spring-integration-core/src/main/java/org/springframework/integration/dsl/ConsumerEndpointSpec.java # spring-integration-core/src/main/java/org/springframework/integration/dsl/PollerSpec.java # spring-integration-core/src/main/java/org/springframework/integration/transaction/TransactionHandleMessageAdvice.java # spring-integration-core/src/main/java/org/springframework/integration/transaction/TransactionInterceptorBuilder.java --- .../integration/dsl/DelayerEndpointSpec.java | 9 +-- .../TransactionHandleMessageAdvice.java | 3 +- .../TransactionInterceptorBuilder.java | 5 ++ .../TransactionInterceptorBuilderTests.java | 5 +- .../jms/ActiveMQMultiContextTests.java | 4 +- .../jms/request_reply/PipelineJmsTests.java | 2 +- .../PipelineNamedReplyQueuesJmsTests.java | 2 +- .../jms/request_reply/pipeline-01.xml | 29 +++------ .../jms/request_reply/pipeline-02.xml | 25 +++----- .../jms/request_reply/pipeline-03.xml | 25 +++----- .../jms/request_reply/pipeline-04.xml | 25 +++----- .../jms/request_reply/pipeline-05.xml | 25 +++----- .../jms/request_reply/pipeline-06.xml | 25 +++----- .../jms/request_reply/pipeline-07.xml | 63 +++++++++---------- .../jms/request_reply/pipeline-08.xml | 25 +++----- .../jms/request_reply/pipeline-09.xml | 25 +++----- .../request_reply/pipeline-named-queue-01.xml | 25 +++----- .../request_reply/pipeline-named-queue-02.xml | 25 +++----- .../pipeline-named-queue-02a.xml | 25 +++----- .../request_reply/pipeline-named-queue-03.xml | 25 +++----- .../pipeline-named-queue-03a.xml | 25 +++----- .../request_reply/pipeline-named-queue-04.xml | 25 +++----- .../request_reply/pipeline-named-queue-05.xml | 25 +++----- .../request_reply/pipeline-named-queue-06.xml | 25 +++----- .../request_reply/pipeline-named-queue-07.xml | 25 +++----- .../mail/dsl/ImapIdleChannelAdapterSpec.java | 11 ++-- 26 files changed, 205 insertions(+), 328 deletions(-) diff --git a/spring-integration-core/src/main/java/org/springframework/integration/dsl/DelayerEndpointSpec.java b/spring-integration-core/src/main/java/org/springframework/integration/dsl/DelayerEndpointSpec.java index 7a27124b46..389bf00b36 100644 --- a/spring-integration-core/src/main/java/org/springframework/integration/dsl/DelayerEndpointSpec.java +++ b/spring-integration-core/src/main/java/org/springframework/integration/dsl/DelayerEndpointSpec.java @@ -31,6 +31,7 @@ import org.springframework.integration.transaction.TransactionInterceptorBuilder import org.springframework.messaging.Message; import org.springframework.messaging.MessageChannel; import org.springframework.transaction.PlatformTransactionManager; +import org.springframework.transaction.TransactionManager; import org.springframework.transaction.interceptor.TransactionInterceptor; import org.springframework.util.Assert; @@ -193,14 +194,14 @@ public class DelayerEndpointSpec extends ConsumerEndpointSpec + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -18,7 +19,6 @@ @@ -31,7 +31,6 @@ @@ -39,22 +38,12 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-02.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-02.xml index 00d79c0134..9b1f1e54d5 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-02.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-02.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -46,16 +48,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-03.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-03.xml index 5169235ad2..dc7c0bff3d 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-03.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-03.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -47,16 +49,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-04.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-04.xml index 9aea09d0b1..da373d76ed 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-04.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-04.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -46,16 +48,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-05.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-05.xml index fd88c0bfbb..a759a4338b 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-05.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-05.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -47,16 +49,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-06.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-06.xml index ba0cfd467f..d62b266d25 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-06.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-06.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -47,16 +49,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-07.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-07.xml index be952daed6..2f81e11d9b 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-07.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-07.xml @@ -1,27 +1,29 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> - + connection-factory="jmsConnectionFactory" + request-destination-name="pipeline07-queue-01" + receive-timeout="10000" + correlation-key="JMSCorrelationID"> + + request-destination-name="pipeline07-queue-01" + connection-factory="jmsConnectionFactory" + concurrent-consumers="10" + reply-timeout="10000"/> @@ -32,32 +34,23 @@ - + connection-factory="jmsConnectionFactory" + request-destination-name="pipeline07-queue-02" + receive-timeout="10000" + correlation-key="foo"> + + request-destination-name="pipeline07-queue-02" + connection-factory="jmsConnectionFactory" + concurrent-consumers="10" + reply-timeout="10000" + correlation-key="foo"/> - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-08.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-08.xml index 5f4437bbf9..b4fe74f47e 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-08.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-08.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -48,16 +50,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-09.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-09.xml index 4b9784a240..af73719f70 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-09.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-09.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -49,16 +51,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-01.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-01.xml index 30fef0a162..554e671dc0 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-01.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-01.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -45,16 +47,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02.xml index 8918d00217..25b0f59353 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -67,16 +69,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02a.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02a.xml index f303697cf0..fd85ea9017 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02a.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-02a.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -69,16 +71,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03.xml index 71fff5f481..b8457d6cd1 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -68,16 +70,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03a.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03a.xml index 4fb8c4c331..13f2281d47 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03a.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-03a.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -95,16 +97,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-04.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-04.xml index 3624e7a0ed..abe48de907 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-04.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-04.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -67,16 +69,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-05.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-05.xml index d93f6efc8c..bf7492a0b1 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-05.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-05.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -50,16 +52,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-06.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-06.xml index 0c454d20d2..974b11dfbb 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-06.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-06.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -51,16 +53,7 @@ - - - - - - - - - - + diff --git a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-07.xml b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-07.xml index a7a95ed947..435a4daa1e 100644 --- a/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-07.xml +++ b/spring-integration-jms/src/test/java/org/springframework/integration/jms/request_reply/pipeline-named-queue-07.xml @@ -1,11 +1,13 @@ + http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/util https://www.springframework.org/schema/util/spring-util.xsd"> @@ -51,16 +53,7 @@ - - - - - - - - - - + diff --git a/spring-integration-mail/src/main/java/org/springframework/integration/mail/dsl/ImapIdleChannelAdapterSpec.java b/spring-integration-mail/src/main/java/org/springframework/integration/mail/dsl/ImapIdleChannelAdapterSpec.java index eb04fc7667..b1ce4359f3 100644 --- a/spring-integration-mail/src/main/java/org/springframework/integration/mail/dsl/ImapIdleChannelAdapterSpec.java +++ b/spring-integration-mail/src/main/java/org/springframework/integration/mail/dsl/ImapIdleChannelAdapterSpec.java @@ -43,7 +43,7 @@ import org.springframework.integration.mapping.HeaderMapper; import org.springframework.integration.support.PropertiesBuilder; import org.springframework.integration.transaction.TransactionInterceptorBuilder; import org.springframework.integration.transaction.TransactionSynchronizationFactory; -import org.springframework.transaction.PlatformTransactionManager; +import org.springframework.transaction.TransactionManager; import org.springframework.transaction.interceptor.TransactionInterceptor; import org.springframework.util.Assert; @@ -311,14 +311,15 @@ public class ImapIdleChannelAdapterSpec /** * Specify a {@link TransactionInterceptor} {@link Advice} with the provided - * {@code PlatformTransactionManager} and default + * {@link TransactionManager} and default * {@link org.springframework.transaction.interceptor.DefaultTransactionAttribute} * for the downstream flow. - * @param transactionManager the {@link PlatformTransactionManager} to use. + * @param transactionManager the {@link TransactionManager} to use. * @return the spec. + * @since 5.2.5 */ - public ImapIdleChannelAdapterSpec transactional(PlatformTransactionManager transactionManager) { - return transactional(new TransactionInterceptorBuilder(false) + public ImapIdleChannelAdapterSpec transactional(TransactionManager transactionManager) { + return transactional(new TransactionInterceptorBuilder(false) .transactionManager(transactionManager) .build()); }