From c8c8160e2da9c16d3a5a0d38467e55d179b472ce Mon Sep 17 00:00:00 2001 From: Gary Russell Date: Wed, 11 Jan 2017 09:53:27 -0500 Subject: [PATCH] Sonar Fixes https://sonar.spring.io/component_issues/index?id=org.springframework.integration%3Aspring-integration%3Amaster#resolved=false|severities=CRITICAL Fix the only 2 code smells that Sonar deems "critical". --- .../file/tail/OSDelegatingFileTailingMessageProducer.java | 2 +- .../springframework/integration/test/mail/TestMailServer.java | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/spring-integration-file/src/main/java/org/springframework/integration/file/tail/OSDelegatingFileTailingMessageProducer.java b/spring-integration-file/src/main/java/org/springframework/integration/file/tail/OSDelegatingFileTailingMessageProducer.java index 6ca5eadfb9..23997a550b 100644 --- a/spring-integration-file/src/main/java/org/springframework/integration/file/tail/OSDelegatingFileTailingMessageProducer.java +++ b/spring-integration-file/src/main/java/org/springframework/integration/file/tail/OSDelegatingFileTailingMessageProducer.java @@ -188,8 +188,8 @@ public class OSDelegatingFileTailingMessageProducer extends FileTailingMessagePr } return; } - final BufferedReader errorReader = new BufferedReader(new InputStreamReader(process.getErrorStream())); this.getTaskExecutor().execute(() -> { + BufferedReader errorReader = new BufferedReader(new InputStreamReader(process.getErrorStream())); String statusMessage; if (logger.isDebugEnabled()) { logger.debug("Reading stderr"); diff --git a/spring-integration-test/src/main/java/org/springframework/integration/test/mail/TestMailServer.java b/spring-integration-test/src/main/java/org/springframework/integration/test/mail/TestMailServer.java index dae82d7fc5..5b44b2c0d2 100644 --- a/spring-integration-test/src/main/java/org/springframework/integration/test/mail/TestMailServer.java +++ b/spring-integration-test/src/main/java/org/springframework/integration/test/mail/TestMailServer.java @@ -97,6 +97,9 @@ public class TestMailServer { write("220 foo SMTP"); while (!socket.isClosed()) { String line = reader.readLine(); + if (line == null) { + break; + } if (line.contains("EHLO")) { write("250-foo hello [0,0,0,0], foo"); write("250-AUTH LOGIN PLAIN");