Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-8748: JDBC locks: use READ_COMMITTED isolation (#8749)

Browse Source 
Fixes https://github.com/spring-projects/spring-integration/issues/8748

The Oracle DB throws `ORA-08177: can't serialize access for this transaction`
when other transaction on the row has begun

* Change the isolation for `DefaultLockRepository.acquire()` transaction
to the `READ_COMMITTED` for what database automatically and silently
restarts the entire SQL statement, and no error occurs.
* Add `oracle` dependencies to JDBC module
* Introduce `OracleContainerTest` and implement it for `OracleLockRegistryTests`

**Cherry-pick to `6.1.x` & `6.0.x`**
This commit is contained in:
Artem Bilan
2023-10-09 11:52:40 -04:00
committed by GitHub
parent ad01c44980
commit fa06940f6d
4 changed files with 229 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/lock/DefaultLockRepository.java
View File

@@ -142,7 +142,7 @@ public class DefaultLockRepository
private TransactionTemplate readOnlyTransactionTemplate;
private TransactionTemplate serializableTransactionTemplate;
private TransactionTemplate readCommittedTransactionTemplate;
private boolean checkDatabaseOnStart = true;
@@ -341,9 +341,9 @@ public class DefaultLockRepository
this.readOnlyTransactionTemplate = new TransactionTemplate(this.transactionManager, transactionDefinition);
transactionDefinition.setReadOnly(false);
transactionDefinition.setIsolationLevel(TransactionDefinition.ISOLATION_SERIALIZABLE);
transactionDefinition.setIsolationLevel(TransactionDefinition.ISOLATION_READ_COMMITTED);
this.serializableTransactionTemplate = new TransactionTemplate(this.transactionManager, transactionDefinition);
this.readCommittedTransactionTemplate = new TransactionTemplate(this.transactionManager, transactionDefinition);
}
/**
@@ -396,7 +396,7 @@ public class DefaultLockRepository
@Override
public boolean acquire(String lock) {
Boolean result =
this.serializableTransactionTemplate.execute(
this.readCommittedTransactionTemplate.execute(
transactionStatus -> {
if (this.template.update(this.updateQuery, this.id, epochMillis(),
this.region, lock, this.id, ttlEpochMillis()) > 0) {