Checkstyle changes

* Upgrade to Checkstyle 9.0
* apply some JavaDocs rules
* Fix JavaDocs rules violations
* Some other minor clean up in the affected classes

spring-integration-jms/src/main/java/org/springframework/integration/jms/config/JmsChannelFactoryBean.java

@@ -120,7 +120,7 @@ public class JmsChannelFactoryBean extends AbstractFactoryBean<AbstractJmsChanne
 
 	private boolean subscriptionShared;
 
-	/**
+	/*
 	 * This value differs from the container implementations' default (which is AUTO_ACKNOWLEDGE)
 	 */
 	private int sessionAcknowledgeMode = Session.SESSION_TRANSACTED;

spring-integration-jms/src/main/java/org/springframework/integration/jms/dsl/JmsInboundGatewaySpec.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2020 the original author or authors.
+ * Copyright 2016-2021 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -212,8 +212,8 @@ public class JmsInboundGatewaySpec<S extends JmsInboundGatewaySpec<S>>
 		/**
 		 * @param destination the destination
 		 * @return the spec.
-		 * @see JmsListenerContainerSpec#destination(Destination)
 		 * @deprecated since 5.5 in favor of {@link #requestDestination(Destination)}
+		 * @see JmsListenerContainerSpec#destination(Destination)
 		 */
 		@Deprecated
 		public JmsInboundGatewayListenerContainerSpec<S, C> destination(Destination destination) {
@@ -224,8 +224,8 @@ public class JmsInboundGatewaySpec<S extends JmsInboundGatewaySpec<S>>
 		 * Specify a request destination for incoming messages.
 		 * @param requestDestination the destination
 		 * @return the spec.
-		 * @see JmsListenerContainerSpec#destination(Destination)
 		 * @since 5.5
+		 * @see JmsListenerContainerSpec#destination(Destination)
 		 */
 		public JmsInboundGatewayListenerContainerSpec<S, C> requestDestination(Destination requestDestination) {
 			this.spec.destination(requestDestination);
@@ -235,8 +235,8 @@ public class JmsInboundGatewaySpec<S extends JmsInboundGatewaySpec<S>>
 		/**
 		 * @param destinationName the destinationName
 		 * @return the spec.
-		 * @see JmsListenerContainerSpec#destination(String)
 		 * @deprecated since 5.5 in favor of {@link #requestDestination(String)}
+		 * @see JmsListenerContainerSpec#destination(String)
 		 */
 		@Deprecated
 		public JmsInboundGatewayListenerContainerSpec<S, C> destination(String destinationName) {
@@ -247,8 +247,8 @@ public class JmsInboundGatewaySpec<S extends JmsInboundGatewaySpec<S>>
 		 * Specify a request destination for incoming messages.
 		 * @param requestDestinationName the destination name
 		 * @return the spec.
-		 * @see JmsListenerContainerSpec#destination(String)
 		 * @since 5.5
+		 * @see JmsListenerContainerSpec#destination(String)
 		 */
 		public JmsInboundGatewayListenerContainerSpec<S, C> requestDestination(String requestDestinationName) {
 			this.spec.destination(requestDestinationName);

spring-integration-jms/src/main/java/org/springframework/integration/jms/dsl/JmsMessageChannelSpec.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2020 the original author or authors.
+ * Copyright 2016-2021 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,6 +31,7 @@ import org.springframework.util.ErrorHandler;
  * {@link org.springframework.integration.jms.AbstractJmsChannel}s.
  *
  * @param <S> the target {@link JmsMessageChannelSpec} implementation type.
+ * @param <T> the target channel implementation type.
  *
  * @author Artem Bilan
  * @author Gary Russell

spring-integration-jms/src/main/java/org/springframework/integration/jms/dsl/JmsOutboundChannelAdapterSpec.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2020 the original author or authors.
+ * Copyright 2016-2021 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -167,8 +167,8 @@ public class JmsOutboundChannelAdapterSpec<S extends JmsOutboundChannelAdapterSp
 	 * @param timeToLiveFunction to use
 	 * @param <P> the expected payload type.
 	 * @return the spec
-	 * @see FunctionExpression
 	 * @since 5.1
+	 * @see FunctionExpression
 	 */
 	public <P> S timeToLiveFunction(Function<Message<P>, ?> timeToLiveFunction) {
 		this.target.setTimeToLiveExpression(new FunctionExpression<>(timeToLiveFunction));

spring-integration-jms/src/main/java/org/springframework/integration/jms/dsl/JmsPollableMessageChannelSpec.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2020 the original author or authors.
+ * Copyright 2016-2021 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -32,6 +32,7 @@ import org.springframework.lang.Nullable;
  * A {@link MessageChannelSpec} for an {@link AbstractJmsChannel}.
  *
  * @param <S> the target {@link JmsPollableMessageChannelSpec} implementation type.
+ * @param <T> the target channel implementation type.
  *
  * @author Artem Bilan
  * @author Gary Russell