From 36c1d5c8c9bc8fbad4ec4324d64a89324b70615b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Seonghyeon=20Cho=20=28=EC=A1=B0=EC=84=B1=ED=98=84=29?= Date: Tue, 20 May 2025 02:12:01 +0900 Subject: [PATCH] Rephrase replication factor documentation (#3909) * Fix docs on `RetryableTopic.replicationFactor()` * Rephrase replicationFactor description about broker version Signed-off-by: Seonghyeon Cho (cherry picked from commit ec154a3b6aaed28c9d15b0a7882358f78128815b) --- .../springframework/kafka/annotation/RetryableTopic.java | 2 +- .../kafka/retrytopic/RetryTopicConfigurationBuilder.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java b/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java index af9a6a60..8f92b889 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java @@ -119,7 +119,7 @@ public @interface RetryableTopic { /** * The replication factor for the automatically created topics. Expressions must * resolve to a short or a String that can be parsed as such. Default is -1 to use the - * broker default if the broker is earlier than version 2.4, an explicit value is + * broker default. If the broker is earlier than version 2.4, an explicit value is * required. * * @return the replication factor. diff --git a/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java b/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java index d52c1c1e..d7b058e2 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java @@ -428,8 +428,8 @@ public class RetryTopicConfigurationBuilder { * Configure the topic creation behavior to auto create topics with the provided * properties. * @param numPartitions the number of partitions. - * @param replicationFactor the replication factor (-1 to use the broker default if the - * broker is version 2.4 or later). + * @param replicationFactor the replication factor (-1 to use the broker default. If the + * broker is earlier than version 2.4, an explicit value is required). * @return the builder. */ public RetryTopicConfigurationBuilder autoCreateTopicsWith(@Nullable Integer numPartitions, @Nullable Short replicationFactor) { @@ -443,8 +443,8 @@ public class RetryTopicConfigurationBuilder { * properties. * @param shouldCreate true to auto create. * @param numPartitions the number of partitions. - * @param replicationFactor the replication factor (-1 to use the broker default if the - * broker is version 2.4 or later). + * @param replicationFactor the replication factor (-1 to use the broker default. If the + * broker is earlier than version 2.4, an explicit value is required). * @return the builder. */ public RetryTopicConfigurationBuilder autoCreateTopics(@Nullable Boolean shouldCreate, @Nullable Integer numPartitions,