From 70a7274c5dd5218f124a89fea282d01bd5007f28 Mon Sep 17 00:00:00 2001 From: Gary Russell Date: Thu, 16 Jun 2022 12:56:11 -0400 Subject: [PATCH] Fix Sonar Issues --- .../PartitionPausingBackOffManagerFactory.java | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/PartitionPausingBackOffManagerFactory.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/PartitionPausingBackOffManagerFactory.java index c6e8ddd5..63dc63f0 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/listener/PartitionPausingBackOffManagerFactory.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/listener/PartitionPausingBackOffManagerFactory.java @@ -51,7 +51,7 @@ public class PartitionPausingBackOffManagerFactory extends AbstractKafkaBackOffM */ public PartitionPausingBackOffManagerFactory(KafkaConsumerTimingAdjuster timingAdjustmentManager) { this.clock = getDefaultClock(); - setTimingAdjustmentManager(timingAdjustmentManager); + doSetTimingAdjustmentManager(timingAdjustmentManager); } /** @@ -62,7 +62,7 @@ public class PartitionPausingBackOffManagerFactory extends AbstractKafkaBackOffM */ public PartitionPausingBackOffManagerFactory(TaskExecutor timingAdjustmentManagerTaskExecutor) { this.clock = getDefaultClock(); - setTaskExecutor(timingAdjustmentManagerTaskExecutor); + doSetTaskExecutor(timingAdjustmentManagerTaskExecutor); } /** @@ -73,7 +73,7 @@ public class PartitionPausingBackOffManagerFactory extends AbstractKafkaBackOffM */ public PartitionPausingBackOffManagerFactory(boolean timingAdjustmentEnabled) { this.clock = getDefaultClock(); - setTimingAdjustmentEnabled(timingAdjustmentEnabled); + this.timingAdjustmentEnabled = timingAdjustmentEnabled; } /** @@ -118,7 +118,11 @@ public class PartitionPausingBackOffManagerFactory extends AbstractKafkaBackOffM * * @param timingAdjustmentManager the adjustmentManager to be used. */ - public final void setTimingAdjustmentManager(KafkaConsumerTimingAdjuster timingAdjustmentManager) { + public void setTimingAdjustmentManager(KafkaConsumerTimingAdjuster timingAdjustmentManager) { + doSetTimingAdjustmentManager(timingAdjustmentManager); + } + + private void doSetTimingAdjustmentManager(KafkaConsumerTimingAdjuster timingAdjustmentManager) { Assert.isTrue(this.timingAdjustmentEnabled, () -> "TimingAdjustment is disabled for this factory."); this.timingAdjustmentManager = timingAdjustmentManager; } @@ -127,7 +131,11 @@ public class PartitionPausingBackOffManagerFactory extends AbstractKafkaBackOffM * Set the {@link TaskExecutor} that will be used in the {@link KafkaConsumerTimingAdjuster}. * @param taskExecutor the taskExecutor to be used. */ - public final void setTaskExecutor(TaskExecutor taskExecutor) { + public void setTaskExecutor(TaskExecutor taskExecutor) { + doSetTaskExecutor(taskExecutor); + } + + private void doSetTaskExecutor(TaskExecutor taskExecutor) { Assert.isTrue(this.timingAdjustmentEnabled, () -> "TimingAdjustment is disabled for this factory."); this.taskExecutor = taskExecutor; }