From aa400fa4b8f6b015b6e7d3af2ec0c2f7b52632d2 Mon Sep 17 00:00:00 2001 From: Artem Yakshin Date: Thu, 18 Oct 2018 14:32:28 -0400 Subject: [PATCH] Doc polishing, remove connectionFactory (cherry picked from commit 2502a8fe1c9759eb78092bca5a1ff6620006c021) --- .../kafka/config/AbstractKafkaListenerEndpoint.java | 2 +- .../springframework/kafka/core/ProducerFactoryUtils.java | 8 ++++---- .../kafka/transaction/KafkaTransactionManager.java | 2 +- src/reference/asciidoc/kafka.adoc | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java b/spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java index b29f85a8..b5017e05 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java @@ -133,7 +133,7 @@ public abstract class AbstractKafkaListenerEndpoint /** * Set the group id to override the {@code group.id} property in the - * connectionFactory. + * ContainerFactory. * @param groupId the group id. * @since 1.3 */ diff --git a/spring-kafka/src/main/java/org/springframework/kafka/core/ProducerFactoryUtils.java b/spring-kafka/src/main/java/org/springframework/kafka/core/ProducerFactoryUtils.java index 3b84bdbf..ed3ff3da 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/core/ProducerFactoryUtils.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/core/ProducerFactoryUtils.java @@ -42,7 +42,7 @@ public final class ProducerFactoryUtils { /** * Obtain a Producer that is synchronized with the current transaction, if any. - * @param producerFactory the ConnectionFactory to obtain a Channel for + * @param producerFactory the ProducerFactory to obtain a Channel for * @param the key type. * @param the value type. * @return the resource holder. @@ -105,12 +105,12 @@ public final class ProducerFactoryUtils { } private static void bindResourceToTransaction(KafkaResourceHolder resourceHolder, - ProducerFactory connectionFactory) { - TransactionSynchronizationManager.bindResource(connectionFactory, resourceHolder); + ProducerFactory producerFactory) { + TransactionSynchronizationManager.bindResource(producerFactory, resourceHolder); resourceHolder.setSynchronizedWithTransaction(true); if (TransactionSynchronizationManager.isSynchronizationActive()) { TransactionSynchronizationManager - .registerSynchronization(new KafkaResourceSynchronization(resourceHolder, connectionFactory)); + .registerSynchronization(new KafkaResourceSynchronization(resourceHolder, producerFactory)); } } diff --git a/spring-kafka/src/main/java/org/springframework/kafka/transaction/KafkaTransactionManager.java b/spring-kafka/src/main/java/org/springframework/kafka/transaction/KafkaTransactionManager.java index 64e1c983..698fcbfd 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/transaction/KafkaTransactionManager.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/transaction/KafkaTransactionManager.java @@ -71,7 +71,7 @@ public class KafkaTransactionManager extends AbstractPlatformTransactionMa private final ProducerFactory producerFactory; /** - * Create a new KafkaTransactionManager, given a ConnectionFactory. + * Create a new KafkaTransactionManager, given a ProducerFactory. * Transaction synchronization is turned off by default, as this manager might be used alongside a datastore-based * Spring transaction manager like DataSourceTransactionManager, which has stronger needs for synchronization. Only * one manager is allowed to drive synchronization at any point of time. diff --git a/src/reference/asciidoc/kafka.adoc b/src/reference/asciidoc/kafka.adoc index 2b10fc99..834d1edc 100644 --- a/src/reference/asciidoc/kafka.adoc +++ b/src/reference/asciidoc/kafka.adoc @@ -1265,12 +1265,12 @@ To configure this feature, set the `idleEventInterval` on the container: [source, java] ---- @Bean -public KafKaMessageListenerContainer(ConnectionFactory connectionFactory) { +public KafkaMessageListenerContainer(ConsumerFactory consumerFactory) { ContainerProperties containerProps = new ContainerProperties("topic1", "topic2"); ... containerProps.setIdleEventInterval(60000L); ... - KafKaMessageListenerContainer container = new KafKaMessageListenerContainer<>(...); + KafkaMessageListenerContainer container = new KafKaMessageListenerContainer<>(...); return container; } ----