From baf21e4782fe0f1eb8467946b92196f8cdff4025 Mon Sep 17 00:00:00 2001 From: Josh Cummings Date: Tue, 9 Aug 2022 12:04:05 -0600 Subject: [PATCH] Polish Mockito Update --- .../ldap/core/LdapTemplateOdmTest.java | 2 +- .../ldap/core/LdapTemplateTest.java | 39 +++++++++---------- ...DirContextAuthenticationStrategyTests.java | 7 ++-- 3 files changed, 22 insertions(+), 26 deletions(-) diff --git a/core/src/test/java/org/springframework/ldap/core/LdapTemplateOdmTest.java b/core/src/test/java/org/springframework/ldap/core/LdapTemplateOdmTest.java index a3bb91af..ad9a18a0 100644 --- a/core/src/test/java/org/springframework/ldap/core/LdapTemplateOdmTest.java +++ b/core/src/test/java/org/springframework/ldap/core/LdapTemplateOdmTest.java @@ -4,7 +4,7 @@ import org.junit.Before; import org.junit.Test; import org.springframework.ldap.odm.core.ObjectDirectoryMapper; -import static org.mockito.Matchers.any; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.doCallRealMethod; import static org.mockito.Mockito.mock; diff --git a/core/src/test/java/org/springframework/ldap/core/LdapTemplateTest.java b/core/src/test/java/org/springframework/ldap/core/LdapTemplateTest.java index 314611ef..1cc9f1cb 100644 --- a/core/src/test/java/org/springframework/ldap/core/LdapTemplateTest.java +++ b/core/src/test/java/org/springframework/ldap/core/LdapTemplateTest.java @@ -16,13 +16,25 @@ package org.springframework.ldap.core; -import org.hamcrest.BaseMatcher; -import org.hamcrest.Description; +import java.util.List; + +import javax.naming.Binding; +import javax.naming.CompositeName; +import javax.naming.Name; +import javax.naming.NamingEnumeration; +import javax.naming.NamingException; +import javax.naming.directory.BasicAttributes; +import javax.naming.directory.DirContext; +import javax.naming.directory.ModificationItem; +import javax.naming.directory.SearchControls; +import javax.naming.directory.SearchResult; +import javax.naming.ldap.LdapContext; +import javax.naming.ldap.LdapName; + import org.junit.Before; import org.junit.Test; import org.mockito.ArgumentCaptor; import org.mockito.ArgumentMatcher; -import org.mockito.verification.VerificationMode; import org.springframework.LdapDataEntry; import org.springframework.dao.EmptyResultDataAccessException; @@ -38,26 +50,11 @@ import org.springframework.ldap.query.LdapQuery; import org.springframework.ldap.query.LdapQueryBuilder; import org.springframework.ldap.support.LdapUtils; -import javax.naming.Binding; -import javax.naming.CompositeName; -import javax.naming.Name; -import javax.naming.NamingEnumeration; -import javax.naming.NamingException; -import javax.naming.directory.BasicAttributes; -import javax.naming.directory.DirContext; -import javax.naming.directory.ModificationItem; -import javax.naming.directory.SearchControls; -import javax.naming.directory.SearchResult; -import javax.naming.ldap.LdapContext; -import javax.naming.ldap.LdapName; - -import java.util.List; - import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.fail; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.argThat; -import static org.mockito.Matchers.eq; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.argThat; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.mock; diff --git a/core/src/test/java/org/springframework/ldap/core/support/DefaultTlsDirContextAuthenticationStrategyTests.java b/core/src/test/java/org/springframework/ldap/core/support/DefaultTlsDirContextAuthenticationStrategyTests.java index cd350b33..4e0e61a3 100644 --- a/core/src/test/java/org/springframework/ldap/core/support/DefaultTlsDirContextAuthenticationStrategyTests.java +++ b/core/src/test/java/org/springframework/ldap/core/support/DefaultTlsDirContextAuthenticationStrategyTests.java @@ -1,13 +1,12 @@ package org.springframework.ldap.core.support; +import javax.naming.ldap.LdapContext; + import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.junit.MockitoJUnitRunner; -import javax.naming.ldap.LdapContext; - -import static org.assertj.core.api.Assertions.*; import static org.mockito.Mockito.verify; /**