From eead369b951ab33b3fb0a28f405d920c30c4b7bd Mon Sep 17 00:00:00 2001 From: Mattias Hellborg Arthursson Date: Mon, 9 Sep 2013 11:32:42 +0200 Subject: [PATCH] Subtle bug in LdapAttribute#remove --- .../java/org/springframework/ldap/core/LdapAttribute.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ldif/ldif-core/src/main/java/org/springframework/ldap/core/LdapAttribute.java b/ldif/ldif-core/src/main/java/org/springframework/ldap/core/LdapAttribute.java index 7d7575ef..becc7b12 100644 --- a/ldif/ldif-core/src/main/java/org/springframework/ldap/core/LdapAttribute.java +++ b/ldif/ldif-core/src/main/java/org/springframework/ldap/core/LdapAttribute.java @@ -15,12 +15,11 @@ */ package org.springframework.ldap.core; +import javax.naming.directory.BasicAttribute; import java.util.Collection; import java.util.HashSet; import java.util.Set; -import javax.naming.directory.BasicAttribute; - /** * Extends {@link javax.naming.directory.BasicAttribute} to add support for * options as defined in RFC2849. @@ -199,7 +198,7 @@ public class LdapAttribute extends BasicAttribute { * @return boolean indicating successful removal of option. */ public boolean removeOption(String option) { - return this.options.remove(options); + return this.options.remove(option); } /**