From 4034dc565caa8e9869e277aaa3dcda528dc40905 Mon Sep 17 00:00:00 2001 From: Vaibhav kulkarni Date: Sat, 25 Jun 2016 10:52:14 +0530 Subject: [PATCH 1/2] added preInvokeSpecial, postInvokeSpecial constants This constants were present in ConstructorCopier class which implements Constants It makes more sence to keep all constant at same place --- .../src/main/java/org/springsource/loaded/Constants.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/springloaded/src/main/java/org/springsource/loaded/Constants.java b/springloaded/src/main/java/org/springsource/loaded/Constants.java index 24b6ca2..f7bca2e 100644 --- a/springloaded/src/main/java/org/springsource/loaded/Constants.java +++ b/springloaded/src/main/java/org/springsource/loaded/Constants.java @@ -30,6 +30,10 @@ import org.objectweb.asm.Opcodes; */ public interface Constants extends Opcodes { + public static final int preInvokeSpecial = 0; + + public static final int postInvokeSpecial = 1; + public static final Integer DEFAULT_INT = Integer.valueOf(0); public static final Byte DEFAULT_BYTE = Byte.valueOf((byte) 0); From 7efb2d9e2db04d94e87cc1ea7147fa4f7ab6e5af Mon Sep 17 00:00:00 2001 From: Vaibhav kulkarni Date: Sat, 25 Jun 2016 10:54:08 +0530 Subject: [PATCH 2/2] moved preInvokeSpecial and postInvokeSpecial constants to Constants interface Constants interface is used to keep all Constants it makes more sence to keep all Constants variables at same place. --- .../main/java/org/springsource/loaded/ConstructorCopier.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/springloaded/src/main/java/org/springsource/loaded/ConstructorCopier.java b/springloaded/src/main/java/org/springsource/loaded/ConstructorCopier.java index b8abf14..ab4c178 100644 --- a/springloaded/src/main/java/org/springsource/loaded/ConstructorCopier.java +++ b/springloaded/src/main/java/org/springsource/loaded/ConstructorCopier.java @@ -25,10 +25,6 @@ import org.objectweb.asm.MethodVisitor; */ class ConstructorCopier extends MethodVisitor implements Constants { - private final static int preInvokeSpecial = 0; - - private final static int postInvokeSpecial = 1; - // It is important to know when an INVOKESPECIAL is hit, whether it is our actual one that delegates to the super or just // one being invoked due to some early object construction prior to the real INVOKESPECIAL running. By tracking // how many unitialized objects there are (count the NEWs) and how many INVOKESPECIALs have occurred, it is possible