GH-503 - Prevent configuration properties from being proxied for observability.

We now avoid proxying configuration properties in the BeanPostProcessor that creates tracing proxies.
This commit is contained in:
Oliver Drotbohm
2024-02-14 11:30:24 +01:00
parent c4c0c2f5be
commit 791910b0c1
3 changed files with 91 additions and 2 deletions

View File

@@ -0,0 +1,24 @@
/*
* Copyright 2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package example.sample;
import org.springframework.boot.context.properties.ConfigurationProperties;
/**
* @author Oliver Drotbohm
*/
@ConfigurationProperties("sample")
public class SampleProperties {}

View File

@@ -0,0 +1,53 @@
/*
* Copyright 2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.modulith.observability;
import static org.assertj.core.api.Assertions.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
import example.sample.SampleProperties;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.beans.factory.support.RootBeanDefinition;
import org.springframework.modulith.runtime.ApplicationModulesRuntime;
/**
* Unit tests for {@link ModuleTracingBeanPostProcessor}.
*
* @author Oliver Drotbohm
*/
public class ModuleTracingBeanPostProcessorUnitTests {
@Test // GH-503
void doesNotProxyConfiguationProperties() {
var beanFactory = new DefaultListableBeanFactory();
beanFactory.registerBeanDefinition("properties", new RootBeanDefinition(SampleProperties.class));
var mock = mock(ApplicationModulesRuntime.class);
doReturn(SampleProperties.class).when(mock).getUserClass(any(), any());
doReturn(true).when(mock).isApplicationClass(any());
var processor = new ModuleTracingBeanPostProcessor(mock, () -> null, beanFactory);
var bean = new SampleProperties();
var result = processor.postProcessAfterInitialization(bean, "properties");
assertThat(result).isSameAs(bean);
}
}