GH-47 - Treat efferent dependencies of configuration properties classes as simple dependencies.

This commit is contained in:
Oliver Drotbohm
2022-10-21 00:56:49 +02:00
parent 2430dc90e2
commit 8591fbb64a
6 changed files with 99 additions and 10 deletions

View File

@@ -0,0 +1,21 @@
/*
* Copyright 2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.acme.myproject.moduleC;
/**
* @author Oliver Drotbohm
*/
public class SomeValueC {}

View File

@@ -0,0 +1,32 @@
/*
* Copyright 2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.acme.myproject.moduleD;
import lombok.RequiredArgsConstructor;
import org.springframework.boot.context.properties.ConfigurationProperties;
import com.acme.myproject.moduleC.SomeValueC;
/**
* @author Oliver Drotbohm
*/
@ConfigurationProperties
@RequiredArgsConstructor
class ConfigurationPropertiesD {
private final SomeValueC value;
}

View File

@@ -19,6 +19,7 @@ import static org.assertj.core.api.Assertions.*;
import org.junit.jupiter.api.Test;
import org.springframework.modulith.model.ApplicationModule;
import org.springframework.modulith.model.ApplicationModule.DependencyType;
import org.springframework.modulith.model.ApplicationModules;
import org.springframework.modulith.model.ApplicationModules.Filters;
import org.springframework.modulith.model.Violations;
@@ -84,4 +85,20 @@ class ModulithTest {
.doesNotContain("moduleA");
});
}
@Test // GH-47
void configrationPropertiesTypesEstablishSimpleDependency() {
var modules = ApplicationModules.of(Application.class, DEFAULT_EXCLUSIONS);
assertThat(modules.getModuleByName("moduleD")).hasValueSatisfying(it -> {
assertThat(it.getDependencies(modules, DependencyType.DEFAULT))
.map(ApplicationModule::getName)
.contains("moduleC"); // ConfigurationProperties -> Value
assertThat(it.getDependencies(modules, DependencyType.USES_COMPONENT))
.isEmpty();
});
}
}