Spring/spring-modulith
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-317 - Detect violations from types located in root packages.

Browse Source 
We now create artificial root application modules for all root packages to detect violations (for example, types located in root packages referring to module-internal types).
This commit is contained in:
Oliver Drotbohm
2023-10-15 19:34:25 +02:00
parent 4a857dcddf
commit 9148a57b02
6 changed files with 151 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-modulith-test/src/main/java/org/springframework/modulith/test/ModuleContextCustomizerFactory.java
View File

@@ -18,6 +18,7 @@ package org.springframework.modulith.test;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import java.util.function.Predicate;
import java.util.function.Supplier;
import java.util.stream.Collectors;
import java.util.stream.Stream;
@@ -191,14 +192,14 @@ class ModuleContextCustomizerFactory implements ContextCustomizerFactory {
* @since 1.1
*/
private static class ModuleTestExecutionBeanDefinitionSelector implements BeanDefinitionRegistryPostProcessor {
private static final Logger LOGGER = LoggerFactory.getLogger(ModuleTestExecutionBeanDefinitionSelector.class);
private final ModuleTestExecution execution;
/**
* Creates a new {@link ModuleTestExecutionBeanDefinitionSelector} for the given {@link ModuleTestExecution}.
*
*
* @param execution must not be {@literal null}.
*/
private ModuleTestExecutionBeanDefinitionSelector(ModuleTestExecution execution) {
@@ -208,7 +209,7 @@ class ModuleContextCustomizerFactory implements ContextCustomizerFactory {
this.execution = execution;
}
/*
/*
* (non-Javadoc)
* @see org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor#postProcessBeanDefinitionRegistry(org.springframework.beans.factory.support.BeanDefinitionRegistry)
*/
@@ -224,7 +225,8 @@ class ModuleContextCustomizerFactory implements ContextCustomizerFactory {
for (String name : registry.getBeanDefinitionNames()) {
var type = factory.getType(name, false);
var module = modules.getModuleByType(type);
var module = modules.getModuleByType(type)
.filter(Predicate.not(ApplicationModule::isRootModule));
// Not a module type -> pass
if (module.isEmpty()) {
@@ -239,15 +241,17 @@ class ModuleContextCustomizerFactory implements ContextCustomizerFactory {
.filter(packagesIncludedInTestRun::contains).isPresent()) {
continue;
}
LOGGER.trace("Dropping bean definition {} for type {} as it is not included in an application module to be bootstrapped!", name, type.getName());
LOGGER.trace(
"Dropping bean definition {} for type {} as it is not included in an application module to be bootstrapped!",
name, type.getName());
// Remove bean definition from bootstrap
registry.removeBeanDefinition(name);
}
}
/*
/*
* (non-Javadoc)
* @see org.springframework.beans.factory.config.BeanFactoryPostProcessor#postProcessBeanFactory(org.springframework.beans.factory.config.ConfigurableListableBeanFactory)
*/