From 9a908ee27509520d8e2f97aeba826d95797daba2 Mon Sep 17 00:00:00 2001 From: Oliver Drotbohm Date: Wed, 7 Aug 2024 21:25:58 +0200 Subject: [PATCH] =?UTF-8?q?GH-754=20-=20Rename=20EventPublication.isPublic?= =?UTF-8?q?ationCompleted()=20to=20=E2=80=A6.isCompleted().?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../modulith/events/EventPublication.java | 12 +++++++++++- .../events/core/TargetEventPublicationUnitTests.java | 2 +- .../JdbcEventPublicationRepositoryPerformance.java | 2 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/spring-modulith-events/spring-modulith-events-api/src/main/java/org/springframework/modulith/events/EventPublication.java b/spring-modulith-events/spring-modulith-events-api/src/main/java/org/springframework/modulith/events/EventPublication.java index f411933c..e3b4c3f9 100644 --- a/spring-modulith-events/spring-modulith-events-api/src/main/java/org/springframework/modulith/events/EventPublication.java +++ b/spring-modulith-events/spring-modulith-events-api/src/main/java/org/springframework/modulith/events/EventPublication.java @@ -76,9 +76,19 @@ public interface EventPublication { /** * Returns whether the publication of the event has completed. * - * @return will never be {@literal null}. + * @deprecated since 1.3, use {@link #isCompleted()} instead. */ + @Deprecated default boolean isPublicationCompleted() { + return isCompleted(); + } + + /** + * Returns whether the publication of the event has completed. + * + * @since 1.3 + */ + default boolean isCompleted() { return getCompletionDate().isPresent(); } diff --git a/spring-modulith-events/spring-modulith-events-core/src/test/java/org/springframework/modulith/events/core/TargetEventPublicationUnitTests.java b/spring-modulith-events/spring-modulith-events-core/src/test/java/org/springframework/modulith/events/core/TargetEventPublicationUnitTests.java index a20098ef..d58e2450 100644 --- a/spring-modulith-events/spring-modulith-events-core/src/test/java/org/springframework/modulith/events/core/TargetEventPublicationUnitTests.java +++ b/spring-modulith-events/spring-modulith-events-core/src/test/java/org/springframework/modulith/events/core/TargetEventPublicationUnitTests.java @@ -48,7 +48,7 @@ class TargetEventPublicationUnitTests { var publication = TargetEventPublication.of(new Object(), PublicationTargetIdentifier.of("foo")); - assertThat(publication.isPublicationCompleted()).isFalse(); + assertThat(publication.isCompleted()).isFalse(); assertThat(publication.getCompletionDate()).isNotPresent(); } } diff --git a/spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryPerformance.java b/spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryPerformance.java index 7e294913..499cc788 100644 --- a/spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryPerformance.java +++ b/spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryPerformance.java @@ -86,7 +86,7 @@ class JdbcEventPublicationRepositoryPerformance { var candidate = publications.get(new Random().nextInt(number)); - if (!candidate.isPublicationCompleted()) { + if (!candidate.isCompleted()) { toComplete = candidate; }