From aedd063e3b0e819e31424c92fe3cb5850144c2e0 Mon Sep 17 00:00:00 2001
From: Oliver Drotbohm <odrotbohm@vmware.com>
Date: Wed, 27 Jul 2022 17:03:02 +0200
Subject: [PATCH] GH-18 - Setup deployment to Artifactory for general builds.

Tweak build to contain a dedicated ci build profile for Javadoc creation post delombokification. Added an artifactory build profile to set up Artifactory deployment for milestones and snapshots.

Cleanups in sonatype build profile to avoid the definition of a snapshot repository to avoid snapshots accidentally be deployed there.
---
 .github/workflows/build.yaml |   6 ++
 pom.xml                      | 147 ++++++++++++++++++++++++-----------
 2 files changed, 108 insertions(+), 45 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d20b99cc..0e370cdd 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -25,3 +25,9 @@ jobs:
 
     - name: Build with Maven
       run: ./mvnw -B
+
+    - name: Deploy to Artifactory
+      env:
+        ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
+        ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
+      run: ./mvnw -B clean deploy -Pci,artifactory
diff --git a/pom.xml b/pom.xml
index 4dfcf2c7..760dfdaa 100644
--- a/pom.xml
+++ b/pom.xml
@@ -96,30 +96,92 @@ limitations under the License.
 				<module>spring-modulith-integration-test</module>
 			</modules>
 
-			<distributionManagement>
-				<snapshotRepository>
-					<id>spring-snapshot</id>
-					<name>Spring Snapshot Repository</name>
-					<url>https://repo.spring.io/snapshot</url>
-				</snapshotRepository>
-			</distributionManagement>
+		</profile>
 
-			<repositories>
-				<repository>
-					<id>spring-snapshot</id>
-					<url>https://repo.spring.io/snapshot</url>
-					<releases>
-						<enabled>false</enabled>
-					</releases>
-				</repository>
-				<repository>
-					<id>spring-milestone</id>
-					<url>https://repo.spring.io/milestone</url>
-					<snapshots>
-						<enabled>false</enabled>
-					</snapshots>
-				</repository>
-			</repositories>
+		<profile>
+
+			<id>ci</id>
+
+			<build>
+				<plugins>
+
+					<plugin>
+						<groupId>org.projectlombok</groupId>
+						<artifactId>lombok-maven-plugin</artifactId>
+						<version>1.18.20.0</version>
+						<configuration>
+							<addOutputDirectory>false</addOutputDirectory>
+							<sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
+						</configuration>
+						<executions>
+							<execution>
+								<phase>generate-sources</phase>
+								<goals>
+									<goal>delombok</goal>
+								</goals>
+							</execution>
+						</executions>
+					</plugin>
+
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-javadoc-plugin</artifactId>
+						<executions>
+							<execution>
+								<id>attach-javadocs</id>
+								<goals>
+									<goal>jar</goal>
+								</goals>
+							</execution>
+						</executions>
+						<configuration>
+							<doclint>none</doclint>
+							<quiet>true</quiet>
+							<show>package</show>
+							<sourcepath>target/generated-sources/delombok</sourcepath>
+						</configuration>
+					</plugin>
+
+				</plugins>
+			</build>
+
+		</profile>
+
+		<profile>
+			<id>artifactory</id>
+			<properties>
+				<maven.test.skip>true</maven.test.skip>
+			</properties>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.jfrog.buildinfo</groupId>
+						<artifactId>artifactory-maven-plugin</artifactId>
+						<version>3.4.0</version>
+						<inherited>false</inherited>
+						<executions>
+							<execution>
+								<id>deploy-to-artifactory</id>
+								<goals>
+									<goal>publish</goal>
+								</goals>
+								<configuration>
+									<publisher>
+										<contextUrl>https://repo.spring.io</contextUrl>
+										<username>${env.ARTIFACTORY_USERNAME}</username>
+										<password>${env.ARTIFACTORY_PASSWORD}</password>
+										<repoKey>libs-milestone-local</repoKey>
+										<snapshotRepoKey>libs-snapshot-local</snapshotRepoKey>
+									</publisher>
+									<buildInfo>
+										<buildName>CI build for Spring Modulith ${project.version}</buildName>
+									</buildInfo>
+								</configuration>
+							</execution>
+						</executions>
+					</plugin>
+				</plugins>
+			</build>
 		</profile>
 
 		<profile>
@@ -142,24 +204,6 @@ limitations under the License.
 							</execution>
 						</executions>
 					</plugin>
-					<plugin>
-						<groupId>org.apache.maven.plugins</groupId>
-						<artifactId>maven-javadoc-plugin</artifactId>
-						<executions>
-							<execution>
-								<id>attach-javadocs</id>
-								<goals>
-									<goal>jar</goal>
-								</goals>
-							</execution>
-						</executions>
-						<configuration>
-							<additionalOptions>
-								<additionalOption>-Xdoclint:none</additionalOption>
-							</additionalOptions>
-							<show>package</show>
-						</configuration>
-					</plugin>
 				</plugins>
 			</build>
 			<distributionManagement>
@@ -167,10 +211,6 @@ limitations under the License.
 					<id>sonatype-new</id>
 					<url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2</url>
 				</repository>
-				<snapshotRepository>
-					<id>sonatype-new</id>
-					<url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
-				</snapshotRepository>
 			</distributionManagement>
 		</profile>
 
@@ -302,4 +342,21 @@ limitations under the License.
 		<tag>main</tag>
 	</scm>
 
+	<repositories>
+		<repository>
+			<id>spring-snapshot</id>
+			<url>https://repo.spring.io/snapshot</url>
+			<releases>
+				<enabled>false</enabled>
+			</releases>
+		</repository>
+		<repository>
+			<id>spring-milestone</id>
+			<url>https://repo.spring.io/milestone</url>
+			<snapshots>
+				<enabled>false</enabled>
+			</snapshots>
+		</repository>
+	</repositories>
+
 </project>