Spring/spring-net
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SPRNET-795 - Change TransactionStatus Rollback setter property to Rollback() method so the contract of setting it to true is more explicit

Browse Source
This commit is contained in:
markpollack
2008-10-03 15:25:47 +00:00
parent e37ac5a43a
commit c1aa74632b
13 changed files with 63 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/Spring/Spring.Data.Tests/Data/AdoPlatformTransactionManagerTests.cs
View File

@@ -768,7 +768,7 @@ namespace Spring.Data
private object TransactionWithExceptionOnRollbackMethod(ITransactionStatus status)
{
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
@@ -961,7 +961,7 @@ namespace Spring.Data
private object TransactionWithPropagationNestedAndRollbackMethod(ITransactionStatus status)
{
Assert.IsTrue(status.IsNewTransaction, "Is new transaction");
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}
@@ -1222,7 +1222,7 @@ namespace Spring.Data
Assert.IsTrue(!status.IsNewTransaction, "Isn't new transaction");
Assert.IsFalse(TransactionSynchronizationManager.CurrentTransactionReadOnly);
Assert.IsFalse(TransactionSynchronizationManager.ActualTransactionActive);
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}
@@ -1256,7 +1256,7 @@ namespace Spring.Data
{
public object DoInTransaction(ITransactionStatus status)
{
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}
@@ -1308,7 +1308,7 @@ namespace Spring.Data
Assert.IsTrue(status.IsNewTransaction, "Is new transaction");
Assert.IsFalse(TransactionSynchronizationManager.CurrentTransactionReadOnly);
Assert.IsTrue(TransactionSynchronizationManager.ActualTransactionActive);
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}
@@ -1402,7 +1402,7 @@ namespace Spring.Data
Assert.IsTrue(TransactionSynchronizationManager.HasResource(dbProvider), "Has thread connection");
Assert.IsTrue(TransactionSynchronizationManager.SynchronizationActive, "Synchronization active");
Assert.IsTrue(!status.IsNewTransaction, "Is existing transaction");
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}

2
test/Spring/Spring.Data.Tests/Data/Core/ServiceDomainTransactionManagerTests.cs
View File

@@ -260,7 +260,7 @@ namespace Spring.Data.Core
Assert.IsTrue(status.IsNewTransaction, "Is new transaction");
Assert.IsFalse(TransactionSynchronizationManager.CurrentTransactionReadOnly);
Assert.IsTrue(TransactionSynchronizationManager.ActualTransactionActive);
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
}

2
test/Spring/Spring.Data.Tests/Data/Core/TxScopeTransactionManagerIntegrationTests.cs
View File

@@ -134,7 +134,7 @@ namespace Spring.Data.Core
TransactionSynchronizationManager.RegisterSynchronization(sync);
Assert.AreEqual("txName", TransactionSynchronizationManager.CurrentTransactionName);
Assert.IsFalse(TransactionSynchronizationManager.CurrentTransactionReadOnly);
status.RollbackOnly = true;
status.SetRollbackOnly();
return null;
}
);

2
test/Spring/Spring.Data.Tests/Data/Core/TxScopeTransactionManagerTests.cs
View File

@@ -171,7 +171,7 @@ namespace Spring.Data.Core
Assert.IsTrue(status2.IsNewTransaction, "Is new transaction");
Assert.IsFalse(TransactionSynchronizationManager.CurrentTransactionReadOnly);
Assert.IsTrue(TransactionSynchronizationManager.ActualTransactionActive);
status2.RollbackOnly = true;
status2.SetRollbackOnly();
return null;
});

2
test/Spring/Spring.Data.Tests/Transaction/Interceptor/AbstractTransactionAspectTests.cs
View File

@@ -229,7 +229,7 @@ namespace Spring.Transaction.Interceptor
public override string GetDescription()
{
ITransactionStatus txStatus = TransactionInterceptor.CurrentTransactionStatus;
txStatus.RollbackOnly = true;
txStatus.SetRollbackOnly();
return "test description";
}

2
test/Spring/Spring.Data.Tests/Transaction/Support/DefaultTransactionStatusTests.cs
View File

@@ -21,7 +21,7 @@ namespace Spring.Transaction.Support
Assert.IsNotNull( stat.SuspendedResources );
Assert.IsTrue( stat.IsNewTransaction );
Assert.IsTrue( ! stat.RollbackOnly );
stat.RollbackOnly = true;
stat.SetRollbackOnly();
Assert.IsTrue( stat.RollbackOnly );
txn.Verify();
}