From c265d4b014c0c7f30ff6e1ad743da6eb8af619a7 Mon Sep 17 00:00:00 2001 From: Andreas Kluth Date: Mon, 8 Oct 2012 23:52:10 +0200 Subject: [PATCH] SPRNET-1495 - Add unit tests to document existing behavior. --- .../TypeConversionUtilsTests.cs | 31 ++++++++++++++++--- .../Spring.Core.Tests.2008.csproj | 1 + .../Spring.Core.Tests.2010.csproj | 1 + 3 files changed, 28 insertions(+), 5 deletions(-) diff --git a/test/Spring/Spring.Core.Tests/Core/TypeConversion/TypeConversionUtilsTests.cs b/test/Spring/Spring.Core.Tests/Core/TypeConversion/TypeConversionUtilsTests.cs index 8fe88761..f6979a34 100644 --- a/test/Spring/Spring.Core.Tests/Core/TypeConversion/TypeConversionUtilsTests.cs +++ b/test/Spring/Spring.Core.Tests/Core/TypeConversion/TypeConversionUtilsTests.cs @@ -31,18 +31,39 @@ namespace Spring.Core.TypeConversion /// This class contains tests for TypeConversionUtils /// /// Mark Pollack + /// Andreas Kluth [TestFixture] public class TypeConversionUtilsTests { - -#if NET_2_0 [Test] public void NullAbleTest() { object o = TypeConversionUtils.ConvertValueIfNecessary(typeof(DateTime?), "", "bla"); Assert.IsNull(o); - } -#endif - + } + + [Test] + [SetCulture( "en-US" )] + public void ConvertValue_ForDecimalMarkWithComma_FailsWithBritishCulture() + { + TestDelegate testDelegate = () => TypeConversionUtils.ConvertValueIfNecessary( typeof( Double ), "1,2", "foo" ); + Assert.Throws( testDelegate ); + } + + [Test] + [SetCulture( "nl-NL" )] + public void ConvertValue_ForDecimalMarkWithPoint_ReturnsValueWithDutchCulture() + { + object o = TypeConversionUtils.ConvertValueIfNecessary( typeof( Double ), "1.2", "foo" ); + Assert.That( o, Is.EqualTo( 1.2 ) ); + } + + [Test] + [SetCulture( "nl-NL" )] + public void ConvertValue_ForDecimalMarkWithComma_ReturnsValueWithDutchCulture() + { + object o = TypeConversionUtils.ConvertValueIfNecessary( typeof( Double ), "1,2", "foo" ); + Assert.That( o, Is.EqualTo( 1.2 ) ); + } } } \ No newline at end of file diff --git a/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2008.csproj b/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2008.csproj index d211800e..58723712 100644 --- a/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2008.csproj +++ b/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2008.csproj @@ -265,6 +265,7 @@ + diff --git a/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2010.csproj b/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2010.csproj index 521fedd1..1abe6791 100644 --- a/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2010.csproj +++ b/test/Spring/Spring.Core.Tests/Spring.Core.Tests.2010.csproj @@ -267,6 +267,7 @@ +