diff --git a/core/src/main/java/org/springframework/plugin/core/OrderAwarePluginRegistry.java b/core/src/main/java/org/springframework/plugin/core/OrderAwarePluginRegistry.java index 99c7b38..3ef969d 100644 --- a/core/src/main/java/org/springframework/plugin/core/OrderAwarePluginRegistry.java +++ b/core/src/main/java/org/springframework/plugin/core/OrderAwarePluginRegistry.java @@ -65,8 +65,6 @@ public class OrderAwarePluginRegistry, S> extends SimplePlug /** * Creates a new {@link OrderAwarePluginRegistry} using the {@code #DEFAULT_COMPARATOR}. * - * @param - * @param * @return */ public static > OrderAwarePluginRegistry create() { @@ -77,8 +75,6 @@ public class OrderAwarePluginRegistry, S> extends SimplePlug * Creates a new {@link OrderAwarePluginRegistry} using the given {@link Comparator} for ordering contained * {@link Plugin}s. * - * @param - * @param * @return */ public static > OrderAwarePluginRegistry create(Comparator comparator) { @@ -88,8 +84,6 @@ public class OrderAwarePluginRegistry, S> extends SimplePlug /** * Creates a new {@link OrderAwarePluginRegistry} with the given plugins. * - * @param - * @param * @param plugins * @return */ @@ -100,8 +94,6 @@ public class OrderAwarePluginRegistry, S> extends SimplePlug /** * Creates a new {@link OrderAwarePluginRegistry} with the given plugins and the order of the plugins reverted. * - * @param - * @param * @param plugins * @return */ @@ -112,8 +104,6 @@ public class OrderAwarePluginRegistry, S> extends SimplePlug /** * Creates a new {@link OrderAwarePluginRegistry} with the given plugins. * - * @param - * @param * @param plugins * @return */ diff --git a/core/src/main/java/org/springframework/plugin/core/PluginRegistry.java b/core/src/main/java/org/springframework/plugin/core/PluginRegistry.java index fa20164..377c895 100644 --- a/core/src/main/java/org/springframework/plugin/core/PluginRegistry.java +++ b/core/src/main/java/org/springframework/plugin/core/PluginRegistry.java @@ -20,19 +20,21 @@ import java.util.Optional; import java.util.function.Supplier; /** - * Registry for plugins. Allows sophisticated typesafe access to implementations of interfaces extending {link Plugin}. + * Registry for {@link Plugin}s. Allows sophisticated typesafe access to implementations of interfaces extending {link + * Plugin}. * - * @param the concrete plugin interface + * @param the concrete {@link Plugin} interface * @param the delimiter type * @author Oliver Gierke */ public interface PluginRegistry, S> extends Iterable { /** - * Returns the first plugin found for the given originating system. Thus, further configured plugins are ignored. + * Returns the first {@link Plugin} found for the given delimiter. Thus, further configured {@link Plugin}s are + * ignored. * - * @param originatingSystem - * @return a plugin for the given originating system or {@code null} if none found + * @param delimiter + * @return a plugin for the given delimiter or {@link Optional#empty()} if none found. */ Optional getPluginFor(S delimiter); @@ -102,7 +104,7 @@ public interface PluginRegistry, S> extends Iterable { * found. * * @param delimiter can be {@literal null}. - * @param plugin must not be {@literal null}. + * @param defaultSupplier must not be {@literal null}. * @return a single {@link Plugin} supporting the given delimiter or the given lazily provided {@link Plugin} if none * found. */ diff --git a/core/src/main/java/org/springframework/plugin/core/SimplePluginRegistry.java b/core/src/main/java/org/springframework/plugin/core/SimplePluginRegistry.java index f257cd7..7423177 100644 --- a/core/src/main/java/org/springframework/plugin/core/SimplePluginRegistry.java +++ b/core/src/main/java/org/springframework/plugin/core/SimplePluginRegistry.java @@ -28,8 +28,6 @@ import org.springframework.util.Assert; * Basic implementation of {@link PluginRegistry}. Simply holds all given plugins in a list dropping {@literal null} * values silently on adding. * - * @param the concrete plugin interface - * @param the delimiter type * @author Oliver Gierke */ public class SimplePluginRegistry, S> extends PluginRegistrySupport { @@ -46,8 +44,6 @@ public class SimplePluginRegistry, S> extends PluginRegistry /** * Creates a new {@link SimplePluginRegistry}. * - * @param the plugin type - * @param the delimiter type * @return */ public static > SimplePluginRegistry create() { @@ -57,8 +53,6 @@ public class SimplePluginRegistry, S> extends PluginRegistry /** * Creates a new {@link SimplePluginRegistry} with the given {@link Plugin} s. * - * @param the plugin type - * @param the delimiter type * @return */ public static > SimplePluginRegistry create(List plugins) { diff --git a/core/src/test/java/org/springframework/plugin/core/SimplePluginRegistryUnitTest.java b/core/src/test/java/org/springframework/plugin/core/SimplePluginRegistryUnitTest.java index 51c7c0a..1587ac9 100644 --- a/core/src/test/java/org/springframework/plugin/core/SimplePluginRegistryUnitTest.java +++ b/core/src/test/java/org/springframework/plugin/core/SimplePluginRegistryUnitTest.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.plugin.core; import static org.hamcrest.CoreMatchers.*;