From 241169c1bea544567e62e6489b099dfce275ef66 Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Mon, 13 Oct 2008 16:05:42 +0000 Subject: [PATCH] * added static factory method to ease instantiation of a new registry * adapted unit test accordingly * polished !JavaDocs a little git-svn-id: svn+ssh://svn.synyx.de/var/svn/synyx/opensource/synyx-plugin/trunk@3010 5a64d73e-33d6-4ccc-9058-23f8668ecac9 --- .../org/synyx/plugin/core/PluginRegistry.java | 15 ++++++++++++++- .../synyx/plugin/core/PluginRegistryUnitTest.java | 7 ++++++- .../PluginConfigurationIntegrationTest.java | 2 ++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/plugin-core/src/main/java/org/synyx/plugin/core/PluginRegistry.java b/plugin-core/src/main/java/org/synyx/plugin/core/PluginRegistry.java index 211cfda..5dcbd83 100644 --- a/plugin-core/src/main/java/org/synyx/plugin/core/PluginRegistry.java +++ b/plugin-core/src/main/java/org/synyx/plugin/core/PluginRegistry.java @@ -20,7 +20,7 @@ public class PluginRegistry, S> implements Iterable { /** - * Constructor of {@code PluginRegistry}. + * Creates a new {@code PluginRegistry}. */ public PluginRegistry() { @@ -28,6 +28,19 @@ public class PluginRegistry, S> implements Iterable { } + /** + * Creates a new {@link PluginRegistry}. + * + * @param + * @param + * @return + */ + public static , S> PluginRegistry create() { + + return new PluginRegistry(); + } + + /** * Register plugins. * diff --git a/plugin-core/src/test/java/org/synyx/plugin/core/PluginRegistryUnitTest.java b/plugin-core/src/test/java/org/synyx/plugin/core/PluginRegistryUnitTest.java index 45dfcba..4da0ae1 100644 --- a/plugin-core/src/test/java/org/synyx/plugin/core/PluginRegistryUnitTest.java +++ b/plugin-core/src/test/java/org/synyx/plugin/core/PluginRegistryUnitTest.java @@ -8,6 +8,11 @@ import org.junit.Before; import org.junit.Test; +/** + * Unit test for {@link PluginRegistry}. + * + * @author Oliver Gierke - gierke@synyx.de + */ public class PluginRegistryUnitTest { private SamplePlugin provider; @@ -24,7 +29,7 @@ public class PluginRegistryUnitTest { provider = new SamplePluginImplementation(); - registry = new PluginRegistry(); + registry = PluginRegistry.create(); registry.setPlugins(Arrays.asList(provider)); } diff --git a/plugin-core/src/test/java/org/synyx/plugin/core/config/PluginConfigurationIntegrationTest.java b/plugin-core/src/test/java/org/synyx/plugin/core/config/PluginConfigurationIntegrationTest.java index 4b68b2a..0d9eceb 100644 --- a/plugin-core/src/test/java/org/synyx/plugin/core/config/PluginConfigurationIntegrationTest.java +++ b/plugin-core/src/test/java/org/synyx/plugin/core/config/PluginConfigurationIntegrationTest.java @@ -12,6 +12,8 @@ import org.synyx.plugin.core.SamplePlugin; /** + * Integration test to simply check if the configuration gets parsed correctly. + * * @author Oliver Gierke - gierke@synyx.de */ @RunWith(SpringJUnit4ClassRunner.class)