diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc index 681b311c..e50b8040 100755 --- a/CONTRIBUTING.adoc +++ b/CONTRIBUTING.adoc @@ -40,10 +40,7 @@ Active contributors might be asked to join the core team, and given the ability None of these is essential for a pull request, but they will all help. They can also be added after the original pull request but before a merge. -* We use the https://github.com/spring-io/spring-javaformat/[Spring JavaFormat] project to apply code formatting conventions. - If you use Eclipse and you follow the '`Importing into eclipse`' instructions below you should get project specific formatting automatically. - You can also install the https://github.com/spring-io/spring-javaformat/#intellij-idea[Spring JavaFormat IntelliJ Plugin] or format the code from the Gradle build by running `./gradlew format`. -// NYI: Note that if you have format violations in `buildSrc`, you can fix them by running `./gradlew -p buildSrc format` from the project root directory. +* We use the https://github.com/spring-io/spring-javaformat/[Spring JavaFormat] project to apply code formatting conventions. The code can be formatted from the Gradle build by running `./gradlew format`. The code can also be formatted from your IDE when the formatter plugin https://github.com/spring-projects-experimental/spring-pulsar/wiki/Working-with-the-Code#install-the-spring-formatter-plugin[has been installed]. * The build includes Checkstyle rules for many of our code conventions. Run `./gradlew checkstyleMain checkstyleTest` if you want to check your changes are compliant. * Make sure all new `.java` files have a Javadoc class comment with at least an `@author` tag identifying you, and preferably at least a paragraph on what the class is for. * Add the ASF license header comment to all new `.java` files (copy from existing files in the project). diff --git a/idea/codeStyleConfig.xml b/idea/codeStyleConfig.xml index cd1c76fe..94162bb1 100644 --- a/idea/codeStyleConfig.xml +++ b/idea/codeStyleConfig.xml @@ -37,7 +37,7 @@ + static="false"/> @@ -53,16 +53,15 @@