From 34dcef2201428f5cd5c4f6723ea66483c0ca41e0 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Wed, 29 Oct 2014 10:04:25 +0000 Subject: [PATCH] Add request method constraints to some request mappings Some request mappings that were only intended to handle GET requests were unconstrained. The commit adds a method = GET constraint to those mappings to prevent them from handling other HTTP request methods --- .../src/main/java/com/example/notes/IndexController.java | 3 ++- .../src/main/java/com/example/notes/NotesController.java | 2 +- .../src/main/java/com/example/notes/TagsController.java | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/rest-notes-spring-hateoas/src/main/java/com/example/notes/IndexController.java b/rest-notes-spring-hateoas/src/main/java/com/example/notes/IndexController.java index 4756f5f6..b8e882b5 100644 --- a/rest-notes-spring-hateoas/src/main/java/com/example/notes/IndexController.java +++ b/rest-notes-spring-hateoas/src/main/java/com/example/notes/IndexController.java @@ -20,13 +20,14 @@ import static org.springframework.hateoas.mvc.ControllerLinkBuilder.linkTo; import org.springframework.hateoas.ResourceSupport; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.RestController; @RestController @RequestMapping("/") public class IndexController { - @RequestMapping + @RequestMapping(method=RequestMethod.GET) public ResourceSupport index() { ResourceSupport index = new ResourceSupport(); index.add(linkTo(NotesController.class).withRel("notes")); diff --git a/rest-notes-spring-hateoas/src/main/java/com/example/notes/NotesController.java b/rest-notes-spring-hateoas/src/main/java/com/example/notes/NotesController.java index de31f824..b61d91e4 100644 --- a/rest-notes-spring-hateoas/src/main/java/com/example/notes/NotesController.java +++ b/rest-notes-spring-hateoas/src/main/java/com/example/notes/NotesController.java @@ -55,7 +55,7 @@ public class NotesController { this.noteResourceAssembler = noteResourceAssembler; } - @RequestMapping + @RequestMapping(method = RequestMethod.GET) Iterable all() { return this.noteResourceAssembler.toResources(this.noteRepository.findAll()); } diff --git a/rest-notes-spring-hateoas/src/main/java/com/example/notes/TagsController.java b/rest-notes-spring-hateoas/src/main/java/com/example/notes/TagsController.java index a89a60e5..9dc227e2 100644 --- a/rest-notes-spring-hateoas/src/main/java/com/example/notes/TagsController.java +++ b/rest-notes-spring-hateoas/src/main/java/com/example/notes/TagsController.java @@ -46,7 +46,7 @@ public class TagsController { this.resourceAssembler = resourceAssembler; } - @RequestMapping + @RequestMapping(method = RequestMethod.GET) Iterable all() { return this.resourceAssembler.toResources(this.repository.findAll()); } @@ -65,7 +65,7 @@ public class TagsController { return httpHeaders; } - @RequestMapping("/{id}") + @RequestMapping(value = "/{id}", method = RequestMethod.GET) Resource tag(@PathVariable("id") long id) { Tag tag = this.repository.findOne(id); return this.resourceAssembler.toResource(tag);