From ccc81f2e5b3fe5fa91e62b1ea16d131206162a65 Mon Sep 17 00:00:00 2001 From: mnhock Date: Tue, 23 Jan 2024 18:21:48 +0100 Subject: [PATCH 1/2] Remove unused String.format call See gh-916 --- .../restdocs/cli/ConcatenatingCommandFormatterTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java b/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java index d0dbf6a6..9d78eea0 100644 --- a/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java +++ b/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java @@ -51,7 +51,7 @@ public class ConcatenatingCommandFormatterTests { @Test public void formattingMultipleElements() { assertThat(this.singleLineFormat.format(Arrays.asList("alpha", "bravo"))) - .isEqualTo(String.format(" alpha bravo")); + .isEqualTo(" alpha bravo"); } } From 79ff75fe6eca5ae4ee9daa12c361f5e498360e65 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Wed, 24 Jan 2024 14:11:13 +0000 Subject: [PATCH 2/2] Polish "Remove unused String.format call" See gh-916 --- .../restdocs/cli/ConcatenatingCommandFormatterTests.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java b/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java index 9d78eea0..54c7cd44 100644 --- a/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java +++ b/spring-restdocs-core/src/test/java/org/springframework/restdocs/cli/ConcatenatingCommandFormatterTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2014-2023 the original author or authors. + * Copyright 2014-2024 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -50,8 +50,7 @@ public class ConcatenatingCommandFormatterTests { @Test public void formattingMultipleElements() { - assertThat(this.singleLineFormat.format(Arrays.asList("alpha", "bravo"))) - .isEqualTo(" alpha bravo"); + assertThat(this.singleLineFormat.format(Arrays.asList("alpha", "bravo"))).isEqualTo(" alpha bravo"); } }