Fix NPE in UrlUtils with null url

Fixes gh-4233
2017-03-02 00:46:01 -06:00
parent 49719480a8
commit 017e9834bd
2 changed files with 24 additions and 1 deletions
--- a/web/src/test/java/org/springframework/security/web/util/UrlUtilsTests.java
+++ b/web/src/test/java/org/springframework/security/web/util/UrlUtilsTests.java
@@ -35,4 +35,24 @@ public class UrlUtilsTests {
 		assertThat(UrlUtils.isAbsoluteUrl("zz+zz.zz-zz://something/")).isTrue();
 	}

+	@Test
+	public void isAbsoluteUrlWhenNullThenFalse() {
+		assertThat(UrlUtils.isAbsoluteUrl(null)).isFalse();
+	}
+
+	@Test
+	public void isAbsoluteUrlWhenEmptyThenFalse() {
+		assertThat(UrlUtils.isAbsoluteUrl("")).isFalse();
+	}
+
+	@Test
+	public void isValidRedirectUrlWhenNullThenFalse() {
+		assertThat(UrlUtils.isValidRedirectUrl(null)).isFalse();
+	}
+
+	@Test
+	public void isValidRedirectUrlWhenEmptyThenFalse() {
+		assertThat(UrlUtils.isValidRedirectUrl("")).isFalse();
+	}
+
 }