diff --git a/core/src/main/java/org/springframework/security/authentication/ProviderManager.java b/core/src/main/java/org/springframework/security/authentication/ProviderManager.java index c313d07d63..c96d35f2aa 100644 --- a/core/src/main/java/org/springframework/security/authentication/ProviderManager.java +++ b/core/src/main/java/org/springframework/security/authentication/ProviderManager.java @@ -178,10 +178,6 @@ public class ProviderManager extends AbstractAuthenticationManager implements Me } public List getProviders() { - if (providers == null || providers.size() == 0) { - throw new IllegalArgumentException("A list of AuthenticationProviders is required"); - } - return providers; } @@ -194,6 +190,7 @@ public class ProviderManager extends AbstractAuthenticationManager implements Me } public void setAuthenticationEventPublisher(AuthenticationEventPublisher eventPublisher) { + Assert.notNull(eventPublisher, "AuthenticationEventPublisher cannot be null"); this.eventPublisher = eventPublisher; } @@ -207,7 +204,7 @@ public class ProviderManager extends AbstractAuthenticationManager implements Me */ @SuppressWarnings("unchecked") public void setProviders(List providers) { - Assert.notNull(providers); + Assert.notNull(providers, "Providers list cannot be null"); for(Object currentObject : providers) { Assert.isInstanceOf(AuthenticationProvider.class, currentObject, "Can only provide AuthenticationProvider instances"); } diff --git a/core/src/test/java/org/springframework/security/authentication/ProviderManagerTests.java b/core/src/test/java/org/springframework/security/authentication/ProviderManagerTests.java index f9276914ad..f63bc66140 100644 --- a/core/src/test/java/org/springframework/security/authentication/ProviderManagerTests.java +++ b/core/src/test/java/org/springframework/security/authentication/ProviderManagerTests.java @@ -85,12 +85,6 @@ public class ProviderManagerTests { mgr.setProviders(providers); } - @Test(expected=IllegalArgumentException.class) - public void getProvidersFailsIfProviderListNotSet() throws Exception { - ProviderManager mgr = new ProviderManager(); - mgr.getProviders(); - } - @Test(expected=IllegalArgumentException.class) public void testStartupFailsIfProvidersNotSet() throws Exception { ProviderManager mgr = new ProviderManager();