Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NPE in OnCommittedResponseWrapper trackContentLength (#3824)

Browse Source 
OnCommittedResponseWrapper trackContentLength will throw a
NullPointerException when the content length passed in is null.

This commit properly tracks the null value as a length of 4.

Fixes gh-3823
This commit is contained in:
Rob Winch
2016-04-19 13:58:56 -05:00
committed by Joe Grandja
parent a5a8aeb550
commit 1dbd3f5906
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/test/java/org/springframework/security/web/util/OnCommittedResponseWrapperTests.java
View File

@@ -545,6 +545,21 @@ public class OnCommittedResponseWrapperTests {
// The amount of content specified in the setContentLength method of the response
// has been greater than zero and has been written to the response.
// gh-3823
@Test
public void contentLengthPrintWriterWriteNullCommits() throws Exception {
String expected = null;
this.response.setContentLength(String.valueOf(expected).length() + 1);
this.response.getWriter().write(expected);
assertThat(this.committed).isFalse();
this.response.getWriter().write("a");
assertThat(this.committed).isTrue();
}
@Test
public void contentLengthPrintWriterWriteIntCommits() throws Exception {
int expected = 1;