Add empty authorities by default
Closes gh-12533
This commit is contained in:
committed by
Steve Riesenberg
parent
6abbdd3654
commit
3229bfa40f
@@ -18,6 +18,8 @@ package org.springframework.security.core.userdetails;
|
||||
|
||||
import java.io.ByteArrayOutputStream;
|
||||
import java.io.ObjectOutputStream;
|
||||
import java.util.ArrayList;
|
||||
import java.util.Collection;
|
||||
import java.util.HashSet;
|
||||
import java.util.List;
|
||||
import java.util.Set;
|
||||
@@ -37,6 +39,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException
|
||||
* Tests {@link User}.
|
||||
*
|
||||
* @author Ben Alex
|
||||
* @author Ilya Starchenko
|
||||
*/
|
||||
public class UserTests {
|
||||
|
||||
@@ -68,6 +71,33 @@ public class UserTests {
|
||||
.isThrownBy(() -> User.class.getDeclaredConstructor((Class[]) null));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testBuildUserWithNoAuthorities() {
|
||||
UserDetails user = User.builder().username("user").password("password").build();
|
||||
assertThat(user.getAuthorities()).isEmpty();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testNullWithinUserAuthoritiesIsRejected() {
|
||||
assertThatIllegalArgumentException().isThrownBy(() -> User.builder().username("user").password("password")
|
||||
.authorities((Collection<? extends GrantedAuthority>) null).build());
|
||||
List<GrantedAuthority> authorities = new ArrayList<>();
|
||||
authorities.add(null);
|
||||
authorities.add(null);
|
||||
assertThatIllegalArgumentException().isThrownBy(
|
||||
() -> User.builder().username("user").password("password").authorities(authorities).build());
|
||||
|
||||
assertThatIllegalArgumentException().isThrownBy(() -> User.builder().username("user").password("password")
|
||||
.authorities((GrantedAuthority[]) null).build());
|
||||
assertThatIllegalArgumentException().isThrownBy(() -> User.builder().username("user").password("password")
|
||||
.authorities(new GrantedAuthority[] { null, null }).build());
|
||||
|
||||
assertThatIllegalArgumentException().isThrownBy(
|
||||
() -> User.builder().username("user").password("password").authorities((String[]) null).build());
|
||||
assertThatIllegalArgumentException().isThrownBy(() -> User.builder().username("user").password("password")
|
||||
.authorities(new String[] { null, null }).build());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testNullValuesRejected() {
|
||||
assertThatIllegalArgumentException().isThrownBy(() -> new User(null, "koala", true, true, true, true, ROLE_12));
|
||||
|
||||
Reference in New Issue
Block a user