Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove redundant throws clauses

Browse Source 
Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.
This commit is contained in:
Lars Grefer
2019-08-23 01:03:54 +02:00
parent f0515a021c
commit 34dd5fea30
418 changed files with 1146 additions and 1273 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
samples/boot/hellowebflux-method/src/integration-test/java/sample/HelloWebfluxMethodApplicationITests.java
View File

@@ -39,7 +39,7 @@ public class HelloWebfluxMethodApplicationITests {
@Test
public void messageWhenNotAuthenticated() throws Exception {
public void messageWhenNotAuthenticated() {
this.rest
.get()
.uri("/message")
@@ -48,7 +48,7 @@ public class HelloWebfluxMethodApplicationITests {
}
@Test
public void messageWhenUserThenForbidden() throws Exception {
public void messageWhenUserThenForbidden() {
this.rest
.get()
.uri("/message")
@@ -58,7 +58,7 @@ public class HelloWebfluxMethodApplicationITests {
}
@Test
public void messageWhenAdminThenOk() throws Exception {
public void messageWhenAdminThenOk() {
this.rest
.get()
.uri("/message")

2
samples/boot/hellowebflux-method/src/main/java/sample/SecurityConfig.java
View File

@@ -36,7 +36,7 @@ import static org.springframework.security.config.Customizer.withDefaults;
public class SecurityConfig {
@Bean
SecurityWebFilterChain springWebFilterChain(ServerHttpSecurity http) throws Exception {
SecurityWebFilterChain springWebFilterChain(ServerHttpSecurity http) {
return http
// Demonstrate that method security works
// Best practice to use both for defense in depth

14
samples/boot/hellowebflux-method/src/test/java/sample/HelloWebfluxMethodApplicationTests.java
View File

@@ -50,7 +50,7 @@ public class HelloWebfluxMethodApplicationTests {
}
@Test
public void messageWhenNotAuthenticated() throws Exception {
public void messageWhenNotAuthenticated() {
this.rest
.get()
.uri("/message")
@@ -61,7 +61,7 @@ public class HelloWebfluxMethodApplicationTests {
// --- Basic Authentication ---
@Test
public void messageWhenUserThenForbidden() throws Exception {
public void messageWhenUserThenForbidden() {
this.rest
.get()
.uri("/message")
@@ -71,7 +71,7 @@ public class HelloWebfluxMethodApplicationTests {
}
@Test
public void messageWhenAdminThenOk() throws Exception {
public void messageWhenAdminThenOk() {
this.rest
.get()
.uri("/message")
@@ -85,7 +85,7 @@ public class HelloWebfluxMethodApplicationTests {
@Test
@WithMockUser
public void messageWhenWithMockUserThenForbidden() throws Exception {
public void messageWhenWithMockUserThenForbidden() {
this.rest
.get()
.uri("/message")
@@ -95,7 +95,7 @@ public class HelloWebfluxMethodApplicationTests {
@Test
@WithMockUser(roles = "ADMIN")
public void messageWhenWithMockAdminThenOk() throws Exception {
public void messageWhenWithMockAdminThenOk() {
this.rest
.get()
.uri("/message")
@@ -107,7 +107,7 @@ public class HelloWebfluxMethodApplicationTests {
// --- mutateWith mockUser ---
@Test
public void messageWhenMutateWithMockUserThenForbidden() throws Exception {
public void messageWhenMutateWithMockUserThenForbidden() {
this.rest
.mutateWith(mockUser())
.get()
@@ -117,7 +117,7 @@ public class HelloWebfluxMethodApplicationTests {
}
@Test
public void messageWhenMutateWithMockAdminThenOk() throws Exception {
public void messageWhenMutateWithMockAdminThenOk() {
this.rest
.mutateWith(mockUser().roles("ADMIN"))
.get()

6
samples/boot/hellowebflux/src/integration-test/java/sample/HelloWebfluxApplicationITests.java
View File

@@ -37,7 +37,7 @@ public class HelloWebfluxApplicationITests {
WebTestClient rest;
@Test
public void basicWhenNoCredentialsThenUnauthorized() throws Exception {
public void basicWhenNoCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -46,7 +46,7 @@ public class HelloWebfluxApplicationITests {
}
@Test
public void basicWhenValidCredentialsThenOk() throws Exception {
public void basicWhenValidCredentialsThenOk() {
this.rest
.get()
.uri("/")
@@ -57,7 +57,7 @@ public class HelloWebfluxApplicationITests {
}
@Test
public void basicWhenInvalidCredentialsThenUnauthorized() throws Exception {
public void basicWhenInvalidCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")

10
samples/boot/hellowebflux/src/test/java/sample/HelloWebfluxApplicationTests.java
View File

@@ -51,7 +51,7 @@ public class HelloWebfluxApplicationTests {
}
@Test
public void basicWhenNoCredentialsThenUnauthorized() throws Exception {
public void basicWhenNoCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -60,7 +60,7 @@ public class HelloWebfluxApplicationTests {
}
@Test
public void basicWhenValidCredentialsThenOk() throws Exception {
public void basicWhenValidCredentialsThenOk() {
this.rest
.get()
.uri("/")
@@ -71,7 +71,7 @@ public class HelloWebfluxApplicationTests {
}
@Test
public void basicWhenInvalidCredentialsThenUnauthorized() throws Exception {
public void basicWhenInvalidCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -82,7 +82,7 @@ public class HelloWebfluxApplicationTests {
}
@Test
public void mockSupportWhenMutateWithMockUserThenOk() throws Exception {
public void mockSupportWhenMutateWithMockUserThenOk() {
this.rest
.mutateWith(mockUser())
.get()
@@ -94,7 +94,7 @@ public class HelloWebfluxApplicationTests {
@Test
@WithMockUser
public void mockSupportWhenWithMockUserThenOk() throws Exception {
public void mockSupportWhenWithMockUserThenOk() {
this.rest
.get()
.uri("/")

6
samples/boot/hellowebfluxfn/src/integration-test/java/sample/HelloWebfluxFnApplicationITests.java
View File

@@ -43,7 +43,7 @@ public class HelloWebfluxFnApplicationITests {
}
@Test
public void basicWhenNoCredentialsThenUnauthorized() throws Exception {
public void basicWhenNoCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -52,7 +52,7 @@ public class HelloWebfluxFnApplicationITests {
}
@Test
public void basicWhenValidCredentialsThenOk() throws Exception {
public void basicWhenValidCredentialsThenOk() {
this.rest
.get()
.uri("/")
@@ -63,7 +63,7 @@ public class HelloWebfluxFnApplicationITests {
}
@Test
public void basicWhenInvalidCredentialsThenUnauthorized() throws Exception {
public void basicWhenInvalidCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")

10
samples/boot/hellowebfluxfn/src/test/java/sample/HelloWebfluxFnApplicationTests.java
View File

@@ -52,7 +52,7 @@ public class HelloWebfluxFnApplicationTests {
}
@Test
public void basicWhenNoCredentialsThenUnauthorized() throws Exception {
public void basicWhenNoCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -61,7 +61,7 @@ public class HelloWebfluxFnApplicationTests {
}
@Test
public void basicWhenValidCredentialsThenOk() throws Exception {
public void basicWhenValidCredentialsThenOk() {
this.rest
.get()
.uri("/")
@@ -72,7 +72,7 @@ public class HelloWebfluxFnApplicationTests {
}
@Test
public void basicWhenInvalidCredentialsThenUnauthorized() throws Exception {
public void basicWhenInvalidCredentialsThenUnauthorized() {
this.rest
.get()
.uri("/")
@@ -83,7 +83,7 @@ public class HelloWebfluxFnApplicationTests {
}
@Test
public void mockSupportWhenMutateWithMockUserThenOk() throws Exception {
public void mockSupportWhenMutateWithMockUserThenOk() {
this.rest
.mutateWith(mockUser())
.get()
@@ -95,7 +95,7 @@ public class HelloWebfluxFnApplicationTests {
@Test
@WithMockUser
public void mockSupportWhenWithMockUserThenOk() throws Exception {
public void mockSupportWhenWithMockUserThenOk() {
this.rest
.get()
.uri("/")

2
samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java
View File

@@ -116,7 +116,7 @@ public class AuthorizationServerConfiguration extends AuthorizationServerConfigu
}
@Override
public void configure(AuthorizationServerEndpointsConfigurer endpoints) throws Exception {
public void configure(AuthorizationServerEndpointsConfigurer endpoints) {
// @formatter:off
endpoints
.authenticationManager(this.authenticationManager)

4
samples/boot/oauth2login/src/integration-test/java/org/springframework/security/samples/OAuth2LoginApplicationTests.java
View File

@@ -291,7 +291,7 @@ public class OAuth2LoginApplicationTests {
assertThat(errorElement.asText()).contains("invalid_redirect_uri_parameter");
}
private void assertLoginPage(HtmlPage page) throws Exception {
private void assertLoginPage(HtmlPage page) {
assertThat(page.getTitleText()).isEqualTo("Please sign in");
int expectedClients = 4;
@@ -322,7 +322,7 @@ public class OAuth2LoginApplicationTests {
}
}
private void assertIndexPage(HtmlPage page) throws Exception {
private void assertIndexPage(HtmlPage page) {
assertThat(page.getTitleText()).isEqualTo("Spring Security - OAuth 2.0 Login");
DomNodeList<HtmlElement> divElements = page.getBody().getElementsByTagName("div");

2
samples/boot/oauth2resourceserver-jwe/src/main/java/org/springframework/boot/env/MockWebServerPropertySource.java vendored
View File

@@ -94,7 +94,7 @@ public class MockWebServerPropertySource extends PropertySource<MockWebServer> i
private void intializeMockWebServer(MockWebServer mockWebServer) {
Dispatcher dispatcher = new Dispatcher() {
@Override
public MockResponse dispatch(RecordedRequest request) throws InterruptedException {
public MockResponse dispatch(RecordedRequest request) {
if ("/.well-known/jwks.json".equals(request.getPath())) {
return JWKS_RESPONSE;
}

2
samples/boot/oauth2resourceserver-webflux/src/main/java/org/springframework/boot/env/MockWebServerPropertySource.java vendored
View File

@@ -93,7 +93,7 @@ public class MockWebServerPropertySource extends PropertySource<MockWebServer> i
private void intializeMockWebServer(MockWebServer mockWebServer) {
Dispatcher dispatcher = new Dispatcher() {
@Override
public MockResponse dispatch(RecordedRequest request) throws InterruptedException {
public MockResponse dispatch(RecordedRequest request) {
if ("/.well-known/jwks.json".equals(request.getPath())) {
return JWKS_RESPONSE;
}

2
samples/boot/oauth2resourceserver-webflux/src/main/java/sample/SecurityConfig.java
View File

@@ -32,7 +32,7 @@ import static org.springframework.security.config.Customizer.withDefaults;
public class SecurityConfig {
@Bean
SecurityWebFilterChain springSecurityFilterChain(ServerHttpSecurity http) throws Exception {
SecurityWebFilterChain springSecurityFilterChain(ServerHttpSecurity http) {
http
.authorizeExchange(exchanges ->
exchanges

2
samples/boot/oauth2resourceserver/src/main/java/org/springframework/boot/env/MockWebServerPropertySource.java vendored
View File

@@ -93,7 +93,7 @@ public class MockWebServerPropertySource extends PropertySource<MockWebServer> i
private void intializeMockWebServer(MockWebServer mockWebServer) {
Dispatcher dispatcher = new Dispatcher() {
@Override
public MockResponse dispatch(RecordedRequest request) throws InterruptedException {
public MockResponse dispatch(RecordedRequest request) {
if ("/.well-known/jwks.json".equals(request.getPath())) {
return JWKS_RESPONSE;
}

2
samples/boot/oauth2webclient-webflux/src/main/java/sample/config/SecurityConfig.java
View File

@@ -32,7 +32,7 @@ import static org.springframework.security.config.Customizer.withDefaults;
public class SecurityConfig {
@Bean
SecurityWebFilterChain configure(ServerHttpSecurity http) throws Exception {
SecurityWebFilterChain configure(ServerHttpSecurity http) {
http
.authorizeExchange(exchanges ->
exchanges

4
samples/boot/webflux-form/src/integration-test/java/sample/WebfluxFormApplicationTests.java
View File

@@ -47,7 +47,7 @@ public class WebfluxFormApplicationTests {
}
@Test
public void loginWhenInvalidUsernameThenError() throws Exception {
public void loginWhenInvalidUsernameThenError() {
LoginPage login = IndexPage.to(this.driver, this.port, LoginPage.class);
login.assertAt();
@@ -60,7 +60,7 @@ public class WebfluxFormApplicationTests {
}
@Test
public void loginAndLogout() throws Exception {
public void loginAndLogout() {
LoginPage login = IndexPage.to(this.driver, this.port, LoginPage.class);
login.assertAt();