Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Sonar Issues

Browse Source 
Fixes gh-4300
This commit is contained in:
Rob Winch
2017-04-18 21:07:00 -05:00
parent 9d9aadb80f
commit 59a0ba285f
7 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
samples/xml/contacts/src/main/java/sample/contact/AdminPermissionController.java
View File

@@ -83,8 +83,8 @@ public final class AdminPermissionController implements MessageSourceAware {
*/
@RequestMapping(value = "/secure/addPermission.htm", method = RequestMethod.GET)
public ModelAndView displayAddPermissionPageForContact(
@RequestParam("contactId") int contactId) {
Contact contact = contactManager.getById(new Long(contactId));
@RequestParam("contactId") long contactId) {
Contact contact = contactManager.getById(contactId);
AddPermission addPermission = new AddPermission();
addPermission.setContact(contact);
@@ -141,10 +141,10 @@ public final class AdminPermissionController implements MessageSourceAware {
* Deletes a permission
*/
@RequestMapping(value = "/secure/deletePermission.htm")
public ModelAndView deletePermission(@RequestParam("contactId") int contactId,
public ModelAndView deletePermission(@RequestParam("contactId") long contactId,
@RequestParam("sid") String sid, @RequestParam("permission") int mask) {
Contact contact = contactManager.getById(new Long(contactId));
Contact contact = contactManager.getById(contactId);
Sid sidObject = new PrincipalSid(sid);
Permission permission = permissionFactory.buildFromMask(mask);