Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish ObservationConvention Configuration

Browse Source 
Change to setObservationConvention so that it reads more clearly
when used, for example `authenticationManager.setObservationConvention`
is clearer than `authenticationManager.setConvention`.

Change unit test names to follow team conventions.

Issue gh-12534
This commit is contained in:
Josh Cummings
2023-03-28 12:20:24 -06:00
parent f1b14de3ba
commit 607e40d366
8 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/java/org/springframework/security/authentication/ObservationAuthenticationManager.java
View File

@@ -63,7 +63,7 @@ public final class ObservationAuthenticationManager implements AuthenticationMan
*
* @since 6.1
*/
public void setConvention(ObservationConvention<AuthenticationObservationContext> convention) {
public void setObservationConvention(ObservationConvention<AuthenticationObservationContext> convention) {
Assert.notNull(convention, "The observation convention cannot be null");
this.convention = convention;
}

2
core/src/main/java/org/springframework/security/authentication/ObservationReactiveAuthenticationManager.java
View File

@@ -70,7 +70,7 @@ public class ObservationReactiveAuthenticationManager implements ReactiveAuthent
*
* @since 6.1
*/
public void setConvention(ObservationConvention<AuthenticationObservationContext> convention) {
public void setObservationConvention(ObservationConvention<AuthenticationObservationContext> convention) {
Assert.notNull(convention, "The observation convention cannot be null");
this.convention = convention;
}

2
core/src/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java
View File

@@ -76,7 +76,7 @@ public final class ObservationAuthorizationManager<T> implements AuthorizationMa
*
* @since 6.1
*/
public void setConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
public void setObservationConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
Assert.notNull(convention, "The observation convention cannot be null");
this.convention = convention;
}

2
core/src/main/java/org/springframework/security/authorization/ObservationReactiveAuthorizationManager.java
View File

@@ -75,7 +75,7 @@ public final class ObservationReactiveAuthorizationManager<T> implements Reactiv
*
* @since 6.1
*/
public void setConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
public void setObservationConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
Assert.notNull(convention, "The observation convention cannot be null");
this.convention = convention;
}