SEC-750: Support for JPA PersistenceContext annotation broken

http://jira.springframework.org/browse/SEC-750. Updates to prevent the HttpSecurityPostProcessor from causing beans to be instantiated. Added a simplified test case to HttpSecurityBeanDefinitionParserTests.

core/src/test/java/org/springframework/security/config/HttpSecurityBeanDefinitionParserTests.java

@@ -345,7 +345,27 @@ public class HttpSecurityBeanDefinitionParserTests {
         List filters = getFilterChainProxy().getFilters("/someurl");
 
         assertFalse(filters.get(1) instanceof SessionFixationProtectionFilter);
-    }    
+    }
+    
+    /**
+     * See SEC-750. If the http security post processor causes beans to be instantiated too eagerly, they way miss
+     * additional processing. In this method we have a UserDetailsService which is referenced from the namespace
+     * and also has a post processor registered which will modify it.
+     */
+    @Test
+    public void httpElementDoesntInterfereWithBeanPostProcessing() {
+        setContext(
+                "<http auto-config='true'/>" +
+                "<authentication-provider user-service-ref='myUserService'/>" +
+                "<b:bean id='myUserService' class='org.springframework.security.config.PostProcessedMockUserDetailsService'/>" +
+                "<b:bean id='beanPostProcessor' class='org.springframework.security.config.MockUserServiceBeanPostProcessor'/>"
+        );
+
+        PostProcessedMockUserDetailsService service = (PostProcessedMockUserDetailsService)appContext.getBean("myUserService");
+
+        assertEquals("Hello from the post processor!", service.getPostProcessorWasHere());
+    }
+    
     
     private void setContext(String context) {
         appContext = new InMemoryXmlApplicationContext(context);

core/src/test/java/org/springframework/security/config/MockUserServiceBeanPostProcessor.java

@@ -0,0 +1,25 @@
+package org.springframework.security.config;
+
+import org.springframework.beans.BeansException;
+import org.springframework.beans.factory.config.BeanPostProcessor;
+
+/**
+ * Test bean post processor which injects a message into a PostProcessedMockUserDetailsService.
+ * 
+ * @author Luke Taylor
+ * @version $Id$
+ */
+public class MockUserServiceBeanPostProcessor implements BeanPostProcessor {
+
+	public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {		
+		return bean;
+	}
+
+	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
+        if (bean instanceof PostProcessedMockUserDetailsService) {
+            ((PostProcessedMockUserDetailsService)bean).setPostProcessorWasHere("Hello from the post processor!");
+        }
+	    
+		return bean;
+	}
+}

core/src/test/java/org/springframework/security/config/PostProcessedMockUserDetailsService.java

@@ -0,0 +1,27 @@
+package org.springframework.security.config;
+
+import org.springframework.dao.DataAccessException;
+import org.springframework.security.userdetails.UserDetails;
+import org.springframework.security.userdetails.UserDetailsService;
+import org.springframework.security.userdetails.UsernameNotFoundException;
+
+public class PostProcessedMockUserDetailsService implements UserDetailsService {
+	private String postProcessorWasHere;
+
+	public PostProcessedMockUserDetailsService() {
+        this.postProcessorWasHere = "Post processor hasn't been yet";
+    }
+
+    public String getPostProcessorWasHere() {
+		return postProcessorWasHere;
+	}
+
+	public void setPostProcessorWasHere(String postProcessorWasHere) {
+		this.postProcessorWasHere = postProcessorWasHere;
+	}
+
+	public UserDetails loadUserByUsername(String username)
+			throws UsernameNotFoundException, DataAccessException {
+		throw new UnsupportedOperationException("Not for actual use");
+	}
+}