ServerSecurityContextRepository members to securityContextRepository
Issue: gh-4822
This commit is contained in:
@@ -49,7 +49,7 @@ public class AuthenticationWebFilter implements WebFilter {
|
||||
|
||||
private ServerAuthenticationFailureHandler serverAuthenticationFailureHandler = new ServerAuthenticationEntryPointFailureHandler(new HttpBasicServerAuthenticationEntryPoint());
|
||||
|
||||
private ServerSecurityContextRepository serverSecurityContextRepository = NoOpServerSecurityContextRepository.getInstance();
|
||||
private ServerSecurityContextRepository securityContextRepository = NoOpServerSecurityContextRepository.getInstance();
|
||||
|
||||
private ServerWebExchangeMatcher requiresAuthenticationMatcher = ServerWebExchangeMatchers.anyExchange();
|
||||
|
||||
@@ -80,15 +80,15 @@ public class AuthenticationWebFilter implements WebFilter {
|
||||
ServerWebExchange exchange = webFilterExchange.getExchange();
|
||||
SecurityContextImpl securityContext = new SecurityContextImpl();
|
||||
securityContext.setAuthentication(authentication);
|
||||
return this.serverSecurityContextRepository.save(exchange, securityContext)
|
||||
return this.securityContextRepository.save(exchange, securityContext)
|
||||
.then(this.serverAuthenticationSuccessHandler
|
||||
.onAuthenticationSuccess(webFilterExchange, authentication));
|
||||
}
|
||||
|
||||
public void setServerSecurityContextRepository(
|
||||
ServerSecurityContextRepository serverSecurityContextRepository) {
|
||||
Assert.notNull(serverSecurityContextRepository, "securityContextRepository cannot be null");
|
||||
this.serverSecurityContextRepository = serverSecurityContextRepository;
|
||||
public void setSecurityContextRepository(
|
||||
ServerSecurityContextRepository securityContextRepository) {
|
||||
Assert.notNull(securityContextRepository, "securityContextRepository cannot be null");
|
||||
this.securityContextRepository = securityContextRepository;
|
||||
}
|
||||
|
||||
public void setServerAuthenticationSuccessHandler(ServerAuthenticationSuccessHandler serverAuthenticationSuccessHandler) {
|
||||
|
||||
@@ -31,25 +31,25 @@ import reactor.core.publisher.Mono;
|
||||
* @since 5.0
|
||||
*/
|
||||
public class SecurityContextServerLogoutHandler implements ServerLogoutHandler {
|
||||
private ServerSecurityContextRepository serverSecurityContextRepository = new WebSessionServerSecurityContextRepository();
|
||||
private ServerSecurityContextRepository securityContextRepository = new WebSessionServerSecurityContextRepository();
|
||||
|
||||
@Override
|
||||
public Mono<Void> logout(WebFilterExchange exchange,
|
||||
Authentication authentication) {
|
||||
return this.serverSecurityContextRepository.save(exchange.getExchange(), null);
|
||||
return this.securityContextRepository.save(exchange.getExchange(), null);
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the {@link ServerSecurityContextRepository} that should be used for logging
|
||||
* out. Default is {@link WebSessionServerSecurityContextRepository}
|
||||
*
|
||||
* @param serverSecurityContextRepository the {@link ServerSecurityContextRepository}
|
||||
* @param securityContextRepository the {@link ServerSecurityContextRepository}
|
||||
* to use.
|
||||
*/
|
||||
public void setServerSecurityContextRepository(
|
||||
ServerSecurityContextRepository serverSecurityContextRepository) {
|
||||
Assert.notNull(serverSecurityContextRepository,
|
||||
"serverSecurityContextRepository cannot be null");
|
||||
this.serverSecurityContextRepository = serverSecurityContextRepository;
|
||||
public void setSecurityContextRepository(
|
||||
ServerSecurityContextRepository securityContextRepository) {
|
||||
Assert.notNull(securityContextRepository,
|
||||
"securityContextRepository cannot be null");
|
||||
this.securityContextRepository = securityContextRepository;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -62,7 +62,7 @@ public class AuthenticationWebFilterTests {
|
||||
@Mock
|
||||
private ServerAuthenticationFailureHandler failureHandler;
|
||||
@Mock
|
||||
private ServerSecurityContextRepository serverSecurityContextRepository;
|
||||
private ServerSecurityContextRepository securityContextRepository;
|
||||
|
||||
private AuthenticationWebFilter filter;
|
||||
|
||||
@@ -71,7 +71,7 @@ public class AuthenticationWebFilterTests {
|
||||
this.filter = new AuthenticationWebFilter(this.authenticationManager);
|
||||
this.filter.setServerAuthenticationSuccessHandler(this.successHandler);
|
||||
this.filter.setAuthenticationConverter(this.authenticationConverter);
|
||||
this.filter.setServerSecurityContextRepository(this.serverSecurityContextRepository);
|
||||
this.filter.setSecurityContextRepository(this.securityContextRepository);
|
||||
this.filter.setServerAuthenticationFailureHandler(this.failureHandler);
|
||||
}
|
||||
|
||||
@@ -154,7 +154,7 @@ public class AuthenticationWebFilterTests {
|
||||
.expectBody(String.class).consumeWith(b -> assertThat(b.getResponseBody()).isEqualTo("ok"))
|
||||
.returnResult();
|
||||
|
||||
verify(this.serverSecurityContextRepository, never()).save(any(), any());
|
||||
verify(this.securityContextRepository, never()).save(any(), any());
|
||||
verifyZeroInteractions(this.authenticationManager, this.successHandler,
|
||||
this.failureHandler);
|
||||
}
|
||||
@@ -174,7 +174,7 @@ public class AuthenticationWebFilterTests {
|
||||
.expectStatus().is5xxServerError()
|
||||
.expectBody().isEmpty();
|
||||
|
||||
verify(this.serverSecurityContextRepository, never()).save(any(), any());
|
||||
verify(this.securityContextRepository, never()).save(any(), any());
|
||||
verifyZeroInteractions(this.authenticationManager, this.successHandler,
|
||||
this.failureHandler);
|
||||
}
|
||||
@@ -185,7 +185,7 @@ public class AuthenticationWebFilterTests {
|
||||
when(this.authenticationConverter.apply(any())).thenReturn(authentication);
|
||||
when(this.authenticationManager.authenticate(any())).thenReturn(authentication);
|
||||
when(this.successHandler.onAuthenticationSuccess(any(), any())).thenReturn(Mono.empty());
|
||||
when(this.serverSecurityContextRepository.save(any(),any())).thenAnswer( a -> Mono.just(a.getArguments()[0]));
|
||||
when(this.securityContextRepository.save(any(),any())).thenAnswer( a -> Mono.just(a.getArguments()[0]));
|
||||
|
||||
WebTestClient client = WebTestClientBuilder
|
||||
.bindToWebFilters(this.filter)
|
||||
@@ -200,7 +200,7 @@ public class AuthenticationWebFilterTests {
|
||||
|
||||
verify(this.successHandler).onAuthenticationSuccess(any(),
|
||||
eq(authentication.block()));
|
||||
verify(this.serverSecurityContextRepository).save(any(), any());
|
||||
verify(this.securityContextRepository).save(any(), any());
|
||||
verifyZeroInteractions(this.failureHandler);
|
||||
}
|
||||
|
||||
@@ -245,7 +245,7 @@ public class AuthenticationWebFilterTests {
|
||||
.expectBody().isEmpty();
|
||||
|
||||
verify(this.failureHandler).onAuthenticationFailure(any(),any());
|
||||
verify(this.serverSecurityContextRepository, never()).save(any(), any());
|
||||
verify(this.securityContextRepository, never()).save(any(), any());
|
||||
verifyZeroInteractions(this.successHandler);
|
||||
}
|
||||
|
||||
@@ -266,7 +266,7 @@ public class AuthenticationWebFilterTests {
|
||||
.expectStatus().is5xxServerError()
|
||||
.expectBody().isEmpty();
|
||||
|
||||
verify(this.serverSecurityContextRepository, never()).save(any(), any());
|
||||
verify(this.securityContextRepository, never()).save(any(), any());
|
||||
verifyZeroInteractions(this.successHandler, this.failureHandler);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user