Remove BaseDigestPasswordEncoder from core

Issue: gh-4674

config/src/main/java/org/springframework/security/config/authentication/PasswordEncoderParser.java

@@ -26,7 +26,6 @@ import org.springframework.beans.factory.config.RuntimeBeanReference;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.beans.factory.xml.ParserContext;
-import org.springframework.security.authentication.encoding.BaseDigestPasswordEncoder;
 import org.springframework.security.authentication.encoding.LdapShaPasswordEncoder;
 import org.springframework.security.config.Elements;
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
@@ -107,16 +106,6 @@ public class PasswordEncoderParser {
 		Class<?> beanClass = ENCODER_CLASSES.get(hash);
 		BeanDefinitionBuilder beanBldr = BeanDefinitionBuilder
 				.rootBeanDefinition(beanClass);
-
-		if (useBase64) {
-			if (BaseDigestPasswordEncoder.class.isAssignableFrom(beanClass)) {
-				beanBldr.addPropertyValue("encodeHashAsBase64", "true");
-			}
-			else {
-				logger.warn(ATT_BASE_64 + " isn't compatible with " + hash
-						+ " and will be ignored");
-			}
-		}
 		return beanBldr.getBeanDefinition();
 	}
 

config/src/main/resources/org/springframework/security/config/spring-security-5.0.rnc

@@ -56,7 +56,7 @@ password-encoder =
 	## element which defines a password encoding strategy. Used by an authentication provider to convert submitted passwords to hashed versions, for example.
 	element password-encoder {password-encoder.attlist, salt-source?}
 password-encoder.attlist &=
-	ref | (hash? & base64?)
+	ref | (hash)
 
 salt-source =
 	## Password salting strategy. A system-wide constant or a property from the UserDetails object can be used.

config/src/main/resources/org/springframework/security/config/spring-security-5.0.xsd

@@ -147,12 +147,6 @@
             </xs:restriction>
          </xs:simpleType>
       </xs:attribute>
-      <xs:attribute name="base64" type="xs:boolean">
-         <xs:annotation>
-            <xs:documentation>Whether a string should be base64 encoded
-                </xs:documentation>
-         </xs:annotation>
-      </xs:attribute>
   </xs:attributeGroup>
   
   <xs:attributeGroup name="user-property">