Added filter chain

core/src/test/java/org/acegisecurity/util/FilterChainProxyTests.java

@@ -0,0 +1,261 @@
+/* Copyright 2004 Acegi Technology Pty Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package net.sf.acegisecurity.util;
+
+import junit.framework.TestCase;
+
+import net.sf.acegisecurity.MockFilterConfig;
+import net.sf.acegisecurity.MockHttpServletRequest;
+import net.sf.acegisecurity.MockHttpServletResponse;
+
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.support.ClassPathXmlApplicationContext;
+
+import java.io.IOException;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.FilterConfig;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+
+/**
+ * Tests {@link FilterChainProxy}.
+ * 
+ * @author Carlos Sanchez
+ * @version $Id$
+ */
+public class FilterChainProxyTests
+    extends TestCase
+{
+    //~ Constructors
+    // ===========================================================
+
+    public FilterChainProxyTests()
+    {
+        super();
+    }
+
+    public FilterChainProxyTests( String arg0 )
+    {
+        super( arg0 );
+    }
+
+    //~ Methods
+    // ================================================================
+
+    public final void setUp() throws Exception
+    {
+        super.setUp();
+//        ApplicationContext applicationContext = new ClassPathXmlApplicationContext(
+//            "net/sf/acegisecurity/util/filtertest-valid.xml" );
+//        FilterChainProxy filterChainProxy = (FilterChainProxy)applicationContext.getBean("filterChain");
+//        System.out.println(filterChainProxy);
+    }
+
+    public static void main( String[] args )
+    {
+        junit.textui.TestRunner.run( FilterChainProxyTests.class );
+    }
+
+    public void testDetectsTargetBeanIsNotAFilter() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetClass", "net.sf.acegisecurity.util.MockNotAFilter" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        try
+        {
+            filter.init( config );
+            fail( "Should have thrown ServletException" );
+        }
+        catch ( ServletException expected )
+        {
+            assertEquals( "Bean 'mockNotAFilter' does not implement javax.servlet.Filter", expected.getMessage() );
+        }
+    }
+
+    public void testDetectsTargetBeanNotInBeanContext() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetBean", "WRONG_NAME" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        try
+        {
+            filter.init( config );
+            fail( "Should have thrown ServletException" );
+        }
+        catch ( ServletException expected )
+        {
+            assertEquals( "targetBean 'WRONG_NAME' not found in context", expected.getMessage() );
+        }
+    }
+
+    public void testIgnoresEmptyTargetBean() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetClass", "net.sf.acegisecurity.util.FilterChainProxy" );
+        config.setInitParmeter( "targetBean", "" );
+
+        // Setup our expectation that the filter chain will be invoked
+        MockFilterChain chain = new MockFilterChain( true );
+
+        MockHttpServletResponse response = new MockHttpServletResponse();
+        MockHttpServletRequest request = new MockHttpServletRequest( "/go" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        executeFilterInContainerSimulator( config, filter, request, response, chain );
+    }
+
+    public void testNormalOperationWithLazyTrue() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetBean", "filterChain" );
+        config.setInitParmeter( "init", "lazy" );
+
+        // Setup our expectation that the filter chain will be invoked
+        MockFilterChain chain = new MockFilterChain( true );
+
+        MockHttpServletResponse response = new MockHttpServletResponse();
+        MockHttpServletRequest request = new MockHttpServletRequest( "/go" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        executeFilterInContainerSimulator( config, filter, request, response, chain );
+    }
+
+    public void testNormalOperationWithSpecificBeanName() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetBean", "filterChain" );
+
+        // Setup our expectation that the filter chain will be invoked
+        MockFilterChain chain = new MockFilterChain( true );
+
+        MockHttpServletResponse response = new MockHttpServletResponse();
+        MockHttpServletRequest request = new MockHttpServletRequest( "/go" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        executeFilterInContainerSimulator( config, filter, request, response, chain );
+    }
+
+    public void testNormalOperationWithTargetClass() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetClass", "net.sf.acegisecurity.util.FilterChainProxy" );
+
+        // Setup our expectation that the filter chain will be invoked
+        MockFilterChain chain = new MockFilterChain( true );
+
+        MockHttpServletResponse response = new MockHttpServletResponse();
+        MockHttpServletRequest request = new MockHttpServletRequest( "/go" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        executeFilterInContainerSimulator( config, filter, request, response, chain );
+    }
+
+    public void testNullDelegateDoesNotCauseNullPointerException() throws Exception
+    {
+        // Setup our filter
+        MockFilterConfig config = new MockFilterConfig();
+        config.setInitParmeter( "targetBean", "aFilterThatDoesntExist" );
+        config.setInitParmeter( "init", "lazy" );
+
+        // Setup our expectation that the filter chain will be invoked
+        MockFilterChain chain = new MockFilterChain( true );
+
+        MockHttpServletResponse response = new MockHttpServletResponse();
+        MockHttpServletRequest request = new MockHttpServletRequest( "/go" );
+
+        FilterToBeanProxy filter = new MockFilterToBeanProxy( "net/sf/acegisecurity/util/filtertest-valid.xml" );
+
+        // do not init (which would hapen if called .doFilter)
+        filter.destroy();
+    }
+
+    private void executeFilterInContainerSimulator( FilterConfig filterConfig, Filter filter, ServletRequest request,
+        ServletResponse response, FilterChain filterChain ) throws ServletException, IOException
+    {
+        filter.init( filterConfig );
+        filter.doFilter( request, response, filterChain );
+        filter.destroy();
+    }
+
+    //~ Inner Classes
+    // ==========================================================
+
+    private class MockFilterChain
+        implements FilterChain
+    {
+        private boolean expectToProceed;
+
+        public MockFilterChain( boolean expectToProceed )
+        {
+            this.expectToProceed = expectToProceed;
+        }
+
+        private MockFilterChain()
+        {
+            super();
+        }
+
+        public void doFilter( ServletRequest request, ServletResponse response ) throws IOException, ServletException
+        {
+            if ( expectToProceed )
+            {
+                assertTrue( true );
+            }
+            else
+            {
+                fail( "Did not expect filter chain to proceed" );
+            }
+        }
+    }
+
+    private class MockFilterToBeanProxy
+        extends FilterToBeanProxy
+    {
+        private String appContextLocation;
+
+        public MockFilterToBeanProxy( String appContextLocation )
+        {
+            this.appContextLocation = appContextLocation;
+        }
+
+        private MockFilterToBeanProxy()
+        {
+            super();
+        }
+
+        protected ApplicationContext getContext( FilterConfig filterConfig )
+        {
+            return new ClassPathXmlApplicationContext( appContextLocation );
+        }
+    }
+}

core/src/test/resources/org/acegisecurity/util/filtertest-valid.xml

@@ -24,4 +24,20 @@
 	<bean id="mockFilter" class="net.sf.acegisecurity.util.MockFilter"/>
 
 	<bean id="mockNotAFilter" class="net.sf.acegisecurity.util.MockNotAFilter"/>
+
+	<bean id="filterChain" class="net.sf.acegisecurity.util.FilterChainProxy">
+      <property name="filterInvocationDefinitionSource">
+         <value>
+                /*=mockFilter
+         </value>
+      </property>
+<!--
+        <property name="filters">
+            <value>
+                /*=mockFilter
+            </value>
+        </property>
+-->
+    </bean>
+
 </beans>