Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IDEA inspection refactorings.

Browse Source
This commit is contained in:
Luke Taylor
2010-08-05 22:47:42 +01:00
parent a3d27a9863
commit 85c4c91e0e
175 changed files with 428 additions and 551 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
samples/tutorial/src/main/java/bigbank/BankDaoStub.java
View File

@@ -5,7 +5,7 @@ import java.util.Map;
public class BankDaoStub implements BankDao {
private long id = 0;
private Map<Long, Account> accounts = new HashMap<Long, Account>();
private final Map<Long, Account> accounts = new HashMap<Long, Account>();
public void createOrUpdateAccount(Account account) {
if (account.getId() == -1) {
@@ -17,12 +17,12 @@ public class BankDaoStub implements BankDao {
}
public Account[] findAccounts() {
Account[] a = accounts.values().toArray(new Account[] {});
System.out.println("Returning " + a.length + " account(s):");
for (int i = 0; i < a.length; i++) {
System.out.println(" > " + a[i]);
Account[] accounts = this.accounts.values().toArray(new Account[] {});
System.out.println("Returning " + accounts.length + " account(s):");
for (Account account : accounts) {
System.out.println(" > " + account);
}
return a;
return accounts;
}
public Account readAccount(Long id) {

2
samples/tutorial/src/main/java/bigbank/BankServiceImpl.java
View File

@@ -4,7 +4,7 @@ import org.aspectj.lang.annotation.Pointcut;
import org.springframework.util.Assert;
public class BankServiceImpl implements BankService {
private BankDao bankDao;
private final BankDao bankDao;
// Not used unless you declare a <protect-pointcut>
@Pointcut("execution(* bigbank.BankServiceImpl.*(..))")

2
samples/tutorial/src/main/java/bigbank/web/ListAccounts.java
View File

@@ -11,7 +11,7 @@ import bigbank.BankService;
public class ListAccounts implements Controller {
private BankService bankService;
private final BankService bankService;
public ListAccounts(BankService bankService) {
Assert.notNull(bankService);

2
samples/tutorial/src/main/java/bigbank/web/PostAccounts.java
View File

@@ -13,7 +13,7 @@ import bigbank.BankService;
public class PostAccounts implements Controller {
private BankService bankService;
private final BankService bankService;
public PostAccounts(BankService bankService) {
Assert.notNull(bankService);